Re: [PATCH] net: stop using mmx intrinsics

2024-03-28 Thread Tyler Retzlaff
On Thu, Mar 21, 2024 at 07:01:17PM +0100, Thomas Monjalon wrote: > 21/03/2024 18:27, Tyler Retzlaff: > > On Thu, Mar 21, 2024 at 06:09:01PM +0100, Thomas Monjalon wrote: > > > 20/03/2024 22:12, Tyler Retzlaff: > > > > +#ifdef RTE_TOOLCHAIN_MSVC > > > > +#include > > > > +#else > > > > #include >

Re: [PATCH] net: stop using mmx intrinsics

2024-03-21 Thread Tyler Retzlaff
On Thu, Mar 21, 2024 at 07:01:17PM +0100, Thomas Monjalon wrote: > 21/03/2024 18:27, Tyler Retzlaff: > > On Thu, Mar 21, 2024 at 06:09:01PM +0100, Thomas Monjalon wrote: > > > 20/03/2024 22:12, Tyler Retzlaff: > > > > +#ifdef RTE_TOOLCHAIN_MSVC > > > > +#include > > > > +#else > > > > #include >

Re: [PATCH] net: stop using mmx intrinsics

2024-03-21 Thread Thomas Monjalon
21/03/2024 18:27, Tyler Retzlaff: > On Thu, Mar 21, 2024 at 06:09:01PM +0100, Thomas Monjalon wrote: > > 20/03/2024 22:12, Tyler Retzlaff: > > > +#ifdef RTE_TOOLCHAIN_MSVC > > > +#include > > > +#else > > > #include > > > +#endif > > > > It is not the same include in MSVC? > > unfortunately in

Re: [PATCH] net: stop using mmx intrinsics

2024-03-21 Thread Tyler Retzlaff
On Thu, Mar 21, 2024 at 06:09:01PM +0100, Thomas Monjalon wrote: > 20/03/2024 22:12, Tyler Retzlaff: > > +#ifdef RTE_TOOLCHAIN_MSVC > > +#include > > +#else > > #include > > +#endif > > It is not the same include in MSVC? unfortunately intrin.h is vestigial in the monolithic approach. to use a

Re: [PATCH] net: stop using mmx intrinsics

2024-03-21 Thread Thomas Monjalon
20/03/2024 22:12, Tyler Retzlaff: > +#ifdef RTE_TOOLCHAIN_MSVC > +#include > +#else > #include > +#endif It is not the same include in MSVC? Is it something we want to wrap in a DPDK header file?

[PATCH] net: stop using mmx intrinsics

2024-03-20 Thread Tyler Retzlaff
Update code to use only avx/sse intrinsics as mmx is not supported on MSVC. Signed-off-by: Tyler Retzlaff --- lib/net/net_crc_avx512.c | 28 ++-- lib/net/net_crc_sse.c| 28 ++-- 2 files changed, 20 insertions(+), 36 deletions(-) diff --git a/l