Re: [PATCH] telemetry: reset data before passing it to callback

2023-02-08 Thread Robin Jarry
Bruce Richardson, Feb 08, 2023 at 10:03: > This is also fixed by patch > http://patches.dpdk.org/project/dpdk/patch/20230120033456.29710-3-fengcheng...@huawei.com/ > > While both work the same way, I think I prefer the fix to set "= {0}" on > init rather than explicit memset. Oh I had missed that

Re: [PATCH] telemetry: reset data before passing it to callback

2023-02-08 Thread Bruce Richardson
On Tue, Feb 07, 2023 at 07:45:20PM +0100, Robin Jarry wrote: > If a telemetry endpoint callback returns 0 without modifying the data > object, output_json() may be called with undefined contents in data. > This can cause crashes and/or worse (double free, etc.). > > Reset data before passing it to

[PATCH] telemetry: reset data before passing it to callback

2023-02-07 Thread Robin Jarry
If a telemetry endpoint callback returns 0 without modifying the data object, output_json() may be called with undefined contents in data. This can cause crashes and/or worse (double free, etc.). Reset data before passing it to the endpoint callbacks. Fixes: 6dd571fd07c3 ("telemetry: introduce ne