RE: [PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-16 Thread Bing Zhao
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, November 16, 2021 6:25 PM > To: Bing Zhao ; Slava Ovsiienko > ; Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: Re: [PATCH] vdpa/mlx5: fix return value check of mkey > create

Re: [PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-16 Thread Maxime Coquelin
On 11/12/21 15:42, Bing Zhao wrote: The return value of "mlx5_os_wrapped_mkey_create" is checked in the caller. A zero means success without any error. The typo in the if-condition should be fixed in case there is a misjudgment. Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR cre

RE: [PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-16 Thread Bing Zhao
Hi, > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, November 16, 2021 4:05 PM > To: Bing Zhao ; Slava Ovsiienko > ; Matan Azrad ; > maxime.coque...@redhat.com > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH] vdpa/mlx5: fix return valu

RE: [PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-16 Thread Xia, Chenbo
> -Original Message- > From: Bing Zhao > Sent: Tuesday, November 16, 2021 4:01 PM > To: Xia, Chenbo ; Slava Ovsiienko > ; Matan Azrad ; > maxime.coque...@redhat.com > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mk

RE: [PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-16 Thread Bing Zhao
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, November 16, 2021 3:54 PM > To: Bing Zhao ; Slava Ovsiienko > ; Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey > create

RE: [PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-15 Thread Xia, Chenbo
> -Original Message- > From: Bing Zhao > Sent: Friday, November 12, 2021 10:43 PM > To: viachesl...@nvidia.com; ma...@nvidia.com > Cc: dev@dpdk.org; rasl...@nvidia.com > Subject: [PATCH] vdpa/mlx5: fix return value check of mkey create > > The return value of &quo

[PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-12 Thread Bing Zhao
The return value of "mlx5_os_wrapped_mkey_create" is checked in the caller. A zero means success without any error. The typo in the if-condition should be fixed in case there is a misjudgment. Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR creation") Signed-off-by: Bing Zhao Acked-