RE: [PATCH 05/11] eal: force prefix for internal threads

2023-09-11 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, 11 September 2023 17.26 > > 07/09/2023 13:10, Morten Brørup: > > > From: David Marchand [mailto:david.march...@redhat.com] > > > Sent: Thursday, 7 September 2023 10.55 > > > > > > On Thu, Sep 7, 2023 at 10:53 AM David Marchand >

Re: [PATCH 05/11] eal: force prefix for internal threads

2023-09-11 Thread Thomas Monjalon
07/09/2023 13:10, Morten Brørup: > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Thursday, 7 September 2023 10.55 > > > > On Thu, Sep 7, 2023 at 10:53 AM David Marchand > > wrote: > > > > > > On Thu, Sep 7, 2023 at 10:50 AM Morten Brørup > > wrote: > > > > > This 10 value i

RE: [PATCH 05/11] eal: force prefix for internal threads

2023-09-07 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 7 September 2023 10.55 > > On Thu, Sep 7, 2023 at 10:53 AM David Marchand > wrote: > > > > On Thu, Sep 7, 2023 at 10:50 AM Morten Brørup > wrote: > > > > This 10 value in the comment is easy to miss if some change with t

Re: [PATCH 05/11] eal: force prefix for internal threads

2023-09-07 Thread David Marchand
On Thu, Sep 7, 2023 at 10:53 AM David Marchand wrote: > > On Thu, Sep 7, 2023 at 10:50 AM Morten Brørup > wrote: > > > This 10 value in the comment is easy to miss if some change with the > > > prefix is done. > > > Mentionning RTE_THREAD_INTERNAL_NAME_SIZE is enough. > > > > I disagree with Dav

Re: [PATCH 05/11] eal: force prefix for internal threads

2023-09-07 Thread David Marchand
On Thu, Sep 7, 2023 at 10:50 AM Morten Brørup wrote: > > This 10 value in the comment is easy to miss if some change with the > > prefix is done. > > Mentionning RTE_THREAD_INTERNAL_NAME_SIZE is enough. > > I disagree with David's comment to this. > > The function documentation is easier to read

RE: [PATCH 05/11] eal: force prefix for internal threads

2023-09-07 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 7 September 2023 10.28 > > On Wed, Sep 6, 2023 at 6:23 PM Thomas Monjalon wrote: > > > > In order to make sure all threads created in DPDK drivers and libraries > > have the same prefix in their name, some wrapper functio

Re: [PATCH 05/11] eal: force prefix for internal threads

2023-09-07 Thread David Marchand
On Wed, Sep 6, 2023 at 6:23 PM Thomas Monjalon wrote: > > In order to make sure all threads created in DPDK drivers and libraries > have the same prefix in their name, some wrapper functions are added > for internal use when creating a control thread or setting a thread name: > - rte_threa

[PATCH 05/11] eal: force prefix for internal threads

2023-09-06 Thread Thomas Monjalon
In order to make sure all threads created in DPDK drivers and libraries have the same prefix in their name, some wrapper functions are added for internal use when creating a control thread or setting a thread name: - rte_thread_create_internal_control - rte_thread_set_prefixed_name