RE: [EXT] Re: [PATCH 1/1] app/mldev: add internal function for file read

2023-04-12 Thread Srikanth Yalavarthi
> -Original Message- > From: Stephen Hemminger > Sent: 28 March 2023 21:22 > To: Srikanth Yalavarthi > Cc: Anup Prabhu ; dev@dpdk.org; Shivah Shankar > Shankar Narayan Rao ; Prince Takkar > ; Srikanth Yalavarthi > Subject: [EXT] Re: [PATCH 1/1] app/mldev: add in

Re: [PATCH 1/1] app/mldev: add internal function for file read

2023-03-28 Thread Stephen Hemminger
On Thu, 23 Mar 2023 08:28:01 -0700 Srikanth Yalavarthi wrote: > + if (fseek(fp, 0, SEEK_END) == 0) { > + file_size = ftell(fp); > + if (file_size == -1) { > + ret = -EIO; > + goto error; > + } > + > + file

[PATCH 1/1] app/mldev: add internal function for file read

2023-03-23 Thread Srikanth Yalavarthi
Added internal function to read model, input and reference files with required error checks. This change fixes the unchecked return value and improper use of negative value issues reported by coverity scan for file read operations. Coverity issue: 383742, 383743 Fixes: f6661e6d9a3a ("app/mldev: va