Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-13 Thread Tyler Retzlaff
On Wed, Mar 13, 2024 at 04:45:36PM -0700, Stephen Hemminger wrote: > On Fri, 2 Feb 2024 13:58:19 -0700 > Ashish Sadanandan wrote: > > > > I think just having the extern "C" guard in all files is the safest > > > choice, > > > because it's immediately obvious in each and every file that it is >

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-13 Thread Ashish Sadanandan
On Wed, Mar 13, 2024 at 2:45 PM Thomas Monjalon wrote: > 13/03/2024 21:26, Ashish Sadanandan: > > On Mon, Feb 12, 2024 at 9:02 AM Morten Brørup > > wrote: > > > > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > > > Sent: Monday, 12 February 2024 16.43 > > > > > > > > On 2/5/2024 9:07 PM

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-13 Thread Thomas Monjalon
13/03/2024 21:26, Ashish Sadanandan: > On Mon, Feb 12, 2024 at 9:02 AM Morten Brørup > wrote: > > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > > Sent: Monday, 12 February 2024 16.43 > > > > > > On 2/5/2024 9:07 PM, Morten Brørup wrote: > > > >> From: Tyler Retzlaff [mailto:roret...@li

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-03-13 Thread Ashish Sadanandan
On Mon, Feb 12, 2024 at 9:02 AM Morten Brørup wrote: > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > Sent: Monday, 12 February 2024 16.43 > > > > On 2/5/2024 9:07 PM, Morten Brørup wrote: > > >> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > >> Sent: Monday, 5 February 20

RE: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-12 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Monday, 12 February 2024 16.43 > > On 2/5/2024 9:07 PM, Morten Brørup wrote: > >> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > >> Sent: Monday, 5 February 2024 18.37 > >> > >> On Fri, Feb 02, 2024 at 09:40:59AM +, Bruce

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-12 Thread Ferruh Yigit
On 2/5/2024 9:07 PM, Morten Brørup wrote: >> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] >> Sent: Monday, 5 February 2024 18.37 >> >> On Fri, Feb 02, 2024 at 09:40:59AM +, Bruce Richardson wrote: >>> On Fri, Feb 02, 2024 at 10:18:23AM +0100, Thomas Monjalon wrote: 02/02/2024

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-12 Thread Ferruh Yigit
On 2/2/2024 9:40 AM, Bruce Richardson wrote: > On Fri, Feb 02, 2024 at 10:18:23AM +0100, Thomas Monjalon wrote: >> 02/02/2024 06:13, Ashish Sadanandan: >>> The header was missing the extern "C" directive which causes name >>> mangling of functions by C++ compilers, leading to linker errors >>> comp

RE: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-05 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Monday, 5 February 2024 18.37 > > On Fri, Feb 02, 2024 at 09:40:59AM +, Bruce Richardson wrote: > > On Fri, Feb 02, 2024 at 10:18:23AM +0100, Thomas Monjalon wrote: > > > 02/02/2024 06:13, Ashish Sadanandan: > > > > The heade

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-05 Thread Tyler Retzlaff
On Fri, Feb 02, 2024 at 09:40:59AM +, Bruce Richardson wrote: > On Fri, Feb 02, 2024 at 10:18:23AM +0100, Thomas Monjalon wrote: > > 02/02/2024 06:13, Ashish Sadanandan: > > > The header was missing the extern "C" directive which causes name > > > mangling of functions by C++ compilers, leading

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-02 Thread Ashish Sadanandan
On Fri, Feb 2, 2024 at 2:41 AM Bruce Richardson wrote: > On Fri, Feb 02, 2024 at 10:18:23AM +0100, Thomas Monjalon wrote: > > 02/02/2024 06:13, Ashish Sadanandan: > > > The header was missing the extern "C" directive which causes name > > > mangling of functions by C++ compilers, leading to linke

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-02 Thread Bruce Richardson
On Fri, Feb 02, 2024 at 10:18:23AM +0100, Thomas Monjalon wrote: > 02/02/2024 06:13, Ashish Sadanandan: > > The header was missing the extern "C" directive which causes name > > mangling of functions by C++ compilers, leading to linker errors > > complaining of undefined references to these functio

Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-02 Thread Thomas Monjalon
02/02/2024 06:13, Ashish Sadanandan: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Fixes: 86c743cf9140 ("eal: define generic vector types") > Cc: n

[PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-01 Thread Ashish Sadanandan
The header was missing the extern "C" directive which causes name mangling of functions by C++ compilers, leading to linker errors complaining of undefined references to these functions. Fixes: 86c743cf9140 ("eal: define generic vector types") Cc: nelio.laranje...@6wind.com Cc: sta...@dpdk.org Si