Re: [PATCH 1/2] drivers: suggestion on meson without version file

2022-10-10 Thread Bruce Richardson
On Mon, Oct 10, 2022 at 10:41:57AM +0300, Omer Yamac wrote: > > > Beware that the shared_lib calls use both lk_deps and lk_args > > parameters, > > which are only set inside the "if" block you added. > > This will cause problems in that: > > 1. If the first driver doesn't have a version.map file,

Re: [PATCH 1/2] drivers: suggestion on meson without version file

2022-10-10 Thread Omer Yamac
On 07.10.2022 13:30, Bruce Richardson wrote: The title of this patch needs an update - I would suggest something like: "build: make version file optional for drivers" Thank you, it will make more sense More comments inline below. On Thu, Oct 06, 2022 at 10:19:22AM +0300, Abdullah Ömer Yam

Re: [PATCH 1/2] drivers: suggestion on meson without version file

2022-10-07 Thread Bruce Richardson
The title of this patch needs an update - I would suggest something like: "build: make version file optional for drivers" More comments inline below. On Thu, Oct 06, 2022 at 10:19:22AM +0300, Abdullah Ömer Yamaç wrote: > Most of the drivers don't have a special version.map file. They just > incl

[PATCH 1/2] drivers: suggestion on meson without version file

2022-10-06 Thread Abdullah Ömer Yamaç
Most of the drivers don't have a special version.map file. They just included due to the compilation issue and needs to be updated for each release. These version.map files include: DPDK_23 { local: *; }; In this patch, we removed the necessity of the version files and you don't need to update