Re: [EXTERNAL] Re: [PATCH 1/2] lib/dmadev: eliminate undefined behavior

2025-01-30 Thread David Marchand
On Fri, Jan 24, 2025 at 12:13 PM David Marchand wrote: > > On Tue, Dec 10, 2024 at 1:58 AM fengchengwen wrote: > > > + @Chengwen Feng > > > > > > This kind of patten is not used other places like ethdev traces, Why we > > > need this kind of pattern in dmadev? > > > Looks like, it can be fixed b

Re: [EXTERNAL] Re: [PATCH 1/2] lib/dmadev: eliminate undefined behavior

2025-01-24 Thread David Marchand
On Tue, Dec 10, 2024 at 1:58 AM fengchengwen wrote: > > + @Chengwen Feng > > > > This kind of patten is not used other places like ethdev traces, Why we > > need this kind of pattern in dmadev? > > Looks like, it can be fixed by caller of this function by initializing > > struct rte_dma_info. So

Re: [EXTERNAL] Re: [PATCH 1/2] lib/dmadev: eliminate undefined behavior

2024-12-09 Thread fengchengwen
On 2024/12/10 7:21, Jerin Jacob wrote: > > >> -Original Message- >> From: Bruce Richardson >> Sent: Monday, December 9, 2024 4:58 AM >> To: Andre Muezerie ; Jerin Jacob >> >> Cc: Chengwen Feng ; Kevin Laatz >> ; dev@dpdk.org >> Sub

RE: [EXTERNAL] Re: [PATCH 1/2] lib/dmadev: eliminate undefined behavior

2024-12-09 Thread Jerin Jacob
> -Original Message- > From: Bruce Richardson > Sent: Monday, December 9, 2024 4:58 AM > To: Andre Muezerie ; Jerin Jacob > > Cc: Chengwen Feng ; Kevin Laatz > ; dev@dpdk.org > Subject: [EXTERNAL] Re: [PATCH 1/2] lib/dmadev: eliminate undefined behavior > &

Re: [PATCH 1/2] lib/dmadev: eliminate undefined behavior

2024-12-09 Thread Bruce Richardson
On Fri, Dec 06, 2024 at 11:27:52AM -0800, Andre Muezerie wrote: > MSVC compiler issues warnings like the one below: > > lib\dmadev\rte_dmadev_trace_fp.h(36): > warning C5101: use of preprocessor directive in > function-like macro argument list is undefined behavior > > Indeed, looking at

[PATCH 1/2] lib/dmadev: eliminate undefined behavior

2024-12-06 Thread Andre Muezerie
MSVC compiler issues warnings like the one below: lib\dmadev\rte_dmadev_trace_fp.h(36): warning C5101: use of preprocessor directive in function-like macro argument list is undefined behavior Indeed, looking at C99 section 6.10.3 Macro replacement, paragraph 11: "If there are sequences of