RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-09 Thread Honnappa Nagarahalli
t Khaparde > (ajit.khapa...@broadcom.com) > Cc: nd > Subject: Re: [PATCH 1/5] ethdev: fix race-condition of proactive error > handling > mode > > > > On 2023/3/9 11:03, Honnappa Nagarahalli wrote: > > > > > >> -Original Message- > >>

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-09 Thread fengchengwen
uh Yigit ; Andrew >> Rybchenko ; Kalesh AP > anakkur.pura...@broadcom.com>; Ajit Khaparde >> (ajit.khapa...@broadcom.com) >> Cc: nd >> Subject: Re: [PATCH 1/5] ethdev: fix race-condition of proactive error >> handling >> mode >> >> >> >>

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-08 Thread Honnappa Nagarahalli
t Khaparde > (ajit.khapa...@broadcom.com) > Cc: nd > Subject: Re: [PATCH 1/5] ethdev: fix race-condition of proactive error > handling > mode > > > > On 2023/3/8 9:09, Honnappa Nagarahalli wrote: > > > > > >>>>>>> > >>>>&g

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-08 Thread Ajit Khaparde
On Tue, Mar 7, 2023 at 4:40 AM Konstantin Ananyev wrote: > > > > > >>> In the proactive error handling mode, the PMD will set the data > > >>> path > > >>> pointers to dummy functions and then try recovery, in this > > >>> period the > > >>> application ma

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-08 Thread fengchengwen
On 2023/3/8 9:09, Honnappa Nagarahalli wrote: > > >>> > > Is there any reason not to design this in the same way as 'rte_eth_dev_reset'? Why does the PMD have to recover by itself? I suppose it is a question for the authors of original patch... >>> Appreciate if the

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Honnappa Nagarahalli
> > > >>> > >>> Is there any reason not to design this in the same way as > >> 'rte_eth_dev_reset'? Why does the PMD have to recover by itself? > >> > >> I suppose it is a question for the authors of original patch... > > Appreciate if the authors could comment on this. > > The main cause is

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Konstantin Ananyev
> >>> In the proactive error handling mode, the PMD will set the data > >>> path > >>> pointers to dummy functions and then try recovery, in this period > >>> the > >>> application may still invoking data path API. This will introduce > >>> a > >

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread fengchengwen
On 2023/3/7 20:07, Ferruh Yigit wrote: > On 3/7/2023 8:25 AM, fengchengwen wrote: >> >> >> On 2023/3/6 19:13, Konstantin Ananyev wrote: >>> >>> >>> In the proactive error handling mode, the PMD will set the data path >>> pointers to dummy functions and then try recovery, in this per

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Ferruh Yigit
On 3/7/2023 8:25 AM, fengchengwen wrote: > > > On 2023/3/6 19:13, Konstantin Ananyev wrote: >> >> >> In the proactive error handling mode, the PMD will set the data path >> pointers to dummy functions and then try recovery, in this period the >> application may still invok

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Konstantin Ananyev
> > > In the proactive error handling mode, the PMD will set the data > > > path > > > pointers to dummy functions and then try recovery, in this period > > > the > > > application may still invoking data path API. This will introduce > > > a > >

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Konstantin Ananyev
> > > > > > > > In the proactive error handling mode, the PMD will set the data > > path pointers to dummy functions and then try recovery, in this > > period the application may still invoking data path API. This will > > introduce a race-condition with data path which m

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Konstantin Ananyev
> > > > In the proactive error handling mode, the PMD will set the data path > > pointers to dummy functions and then try recovery, in this period > > the > > application may still invoking data path API. This will introduce a > > race-condition with data

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread fengchengwen
uh Yigit ; Andrew >> Rybchenko ; Kalesh AP > anakkur.pura...@broadcom.com>; Ajit Khaparde >> (ajit.khapa...@broadcom.com) >> Cc: nd >> Subject: Re: [PATCH 1/5] ethdev: fix race-condition of proactive error >> handling >> mode >> >> >>>>>&

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread fengchengwen
On 2023/3/6 19:13, Konstantin Ananyev wrote: > > > In the proactive error handling mode, the PMD will set the data path > pointers to dummy functions and then try recovery, in this period the > application may still invoking data path API. This will introduce a

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Honnappa Nagarahalli
t Khaparde > (ajit.khapa...@broadcom.com) > Cc: nd > Subject: Re: [PATCH 1/5] ethdev: fix race-condition of proactive error > handling > mode > > > >>>> > >>>> In the proactive error handling mode, the PMD will set the data > >>>> path po

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Konstantin Ananyev
> > >> In the proactive error handling mode, the PMD will set the data path > > >> pointers to dummy functions and then try recovery, in this period the > > >> application may still invoking data path API. This will introduce a > > >> race-condition with data path which may lead t

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Ajit Khaparde
On Mon, Mar 6, 2023 at 3:00 AM Ferruh Yigit wrote: > > On 3/6/2023 10:22 AM, Konstantin Ananyev wrote: > > > > > >> In the proactive error handling mode, the PMD will set the data path > >> pointers to dummy functions and then try recovery, in this period the > >> application may still

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Ferruh Yigit
On 3/6/2023 10:22 AM, Konstantin Ananyev wrote: > > >> In the proactive error handling mode, the PMD will set the data path >> pointers to dummy functions and then try recovery, in this period the >> application may still invoking data path API. This will introduce a >> race-condi

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Konstantin Ananyev
> In the proactive error handling mode, the PMD will set the data path > pointers to dummy functions and then try recovery, in this period the > application may still invoking data path API. This will introduce a > race-condition with data path which may lead to crash [1]. > >

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Ferruh Yigit
On 3/6/2023 1:41 AM, fengchengwen wrote: >> What if application is not interested in recovery modes at all and not >> registered any callback for the recover> > There's probably race-condition which may lead to crash, because DPDK worker > threads runs busyloop and located on isolated core, and als

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Ferruh Yigit
On 3/6/2023 1:41 AM, fengchengwen wrote: > On 2023/3/4 0:51, Ferruh Yigit wrote: >> On 3/2/2023 12:08 PM, Konstantin Ananyev wrote: >>> In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the applicati

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Ferruh Yigit
On 3/5/2023 2:53 PM, Konstantin Ananyev wrote: > 03/03/2023 16:51, Ferruh Yigit пишет: >> On 3/2/2023 12:08 PM, Konstantin Ananyev wrote: >>> In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the app

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-05 Thread fengchengwen
On 2023/3/4 0:51, Ferruh Yigit wrote: > On 3/2/2023 12:08 PM, Konstantin Ananyev wrote: >> >>> In the proactive error handling mode, the PMD will set the data path >>> pointers to dummy functions and then try recovery, in this period the >>> application may still invoking data path API. This will i

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-05 Thread Konstantin Ananyev
In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a race-condition with data path which may lead to crash [1]. Although the PMD added dela

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-05 Thread Konstantin Ananyev
03/03/2023 16:51, Ferruh Yigit пишет: On 3/2/2023 12:08 PM, Konstantin Ananyev wrote: In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a r

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-03 Thread Honnappa Nagarahalli
> -Original Message- > From: Konstantin Ananyev > Sent: Thursday, March 2, 2023 6:22 PM > To: dev@dpdk.org > Subject: Re: [PATCH 1/5] ethdev: fix race-condition of proactive error > handling > mode > > > > > > >> -Original Mes

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-03 Thread Ferruh Yigit
On 3/2/2023 12:08 PM, Konstantin Ananyev wrote: > >> In the proactive error handling mode, the PMD will set the data path >> pointers to dummy functions and then try recovery, in this period the >> application may still invoking data path API. This will introduce a >> race-condition with data path

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-02 Thread Konstantin Ananyev
race-condition of proactive error handling mode In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a race-condition with data path which may

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-02 Thread Honnappa Nagarahalli
broadcom.com) > Cc: dev@dpdk.org > Subject: [PATCH 1/5] ethdev: fix race-condition of proactive error handling > mode > > In the proactive error handling mode, the PMD will set the data path pointers > to > dummy functions and then try recovery, in this period the applicatio

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-02 Thread Konstantin Ananyev
> In the proactive error handling mode, the PMD will set the data path > pointers to dummy functions and then try recovery, in this period the > application may still invoking data path API. This will introduce a > race-condition with data path which may lead to crash [1]. > > Although the PMD a

[PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-02-28 Thread Chengwen Feng
In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a race-condition with data path which may lead to crash [1]. Although the PMD added delay aft