Re: [PATCH 1/7] vhost: fix missing vring call check on virtqueue access

2023-10-20 Thread Maxime Coquelin
On 10/19/23 09:24, David Marchand wrote: On Mon, Sep 25, 2023 at 6:36 PM Maxime Coquelin wrote: Acquiring the access lock is not enough to ensure virtqueue's metadata such as vring pointers are valid. The access status must also be checked. Even if adding the lock was not enough, I would

Re: [PATCH 1/7] vhost: fix missing vring call check on virtqueue access

2023-10-19 Thread David Marchand
On Mon, Sep 25, 2023 at 6:36 PM Maxime Coquelin wrote: > > Acquiring the access lock is not enough to ensure > virtqueue's metadata such as vring pointers are valid. > > The access status must also be checked. Even if adding the lock was not enough, I would flag Fixes: 6c299bb7322f ("vhost: intro

[PATCH 1/7] vhost: fix missing vring call check on virtqueue access

2023-09-25 Thread Maxime Coquelin
Acquiring the access lock is not enough to ensure virtqueue's metadata such as vring pointers are valid. The access status must also be checked. Fixes: c5736998305d ("vhost: fix missing virtqueue lock protection") Fixes: 830f7e790732 ("vhost: add non-blocking API for posting interrupt") Cc: sta..