Re: [PATCH 10/25] common/idpf: avoid variable 0-init

2024-05-29 Thread Bruce Richardson
On Tue, May 28, 2024 at 07:35:50AM +, Soumyadeep Hore wrote: > Dont initialize the variables if not needed. > > Also use 'err' instead of 'status', 'ret_code', 'ret' etc. > for consistency and change the return label 'sq_send_command_out' > to 'err_unlock'. This is consistency of naming withi

[PATCH 10/25] common/idpf: avoid variable 0-init

2024-05-28 Thread Soumyadeep Hore
Dont initialize the variables if not needed. Also use 'err' instead of 'status', 'ret_code', 'ret' etc. for consistency and change the return label 'sq_send_command_out' to 'err_unlock'. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 60 +-- .