Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant function.

Signed-off-by: Jie Hai <haij...@huawei.com>
---
 lib/security/rte_security.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c
index b082a290296b..e20d610172ef 100644
--- a/lib/security/rte_security.c
+++ b/lib/security/rte_security.c
@@ -496,13 +496,14 @@ security_handle_cryptodev_crypto_caps(const char *cmd 
__rte_unused, const char *
        int dev_id, capa_id;
        int crypto_caps_n;
        char *end_param;
+       char *sp = NULL;
        int rc;
 
        if (!params || strlen(params) == 0 || !isdigit(*params))
                return -EINVAL;
 
        dev_id = strtoul(params, &end_param, 0);
-       capa_param = strtok(end_param, ",");
+       capa_param = strtok_r(end_param, ",", &sp);
        if (!capa_param || strlen(capa_param) == 0 || !isdigit(*capa_param))
                return -EINVAL;
 
-- 
2.30.0

Reply via email to