RE: [PATCH 2/2] lib/hash: avoid implicit conversion to 64 bit number

2025-01-25 Thread Morten Brørup
> > How about reducing the formula to directly shift the sizeof() > instead, i.e.: > > sizeof(uint32_t) << ctx->reta_sz_log, > > Shifting the sizeof() directly is better indeed. Let me know how we > should > proceed. Do you want me to send out a new series incorporating this > suggestion? Yes, pl

Re: [PATCH 2/2] lib/hash: avoid implicit conversion to 64 bit number

2025-01-23 Thread Andre Muezerie
On Thu, Jan 23, 2025 at 08:55:29AM +0100, Morten Brørup wrote: > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > > Sent: Wednesday, 22 January 2025 22.37 > > > > On Wed, Jan 22, 2025 at 04:12:49PM +, Bruce Richardson wrote: > > > On Wed, Nov 27, 2024 at 05:53:57PM -0800, Andre M

RE: [PATCH 2/2] lib/hash: avoid implicit conversion to 64 bit number

2025-01-22 Thread Morten Brørup
> From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > Sent: Wednesday, 22 January 2025 22.37 > > On Wed, Jan 22, 2025 at 04:12:49PM +, Bruce Richardson wrote: > > On Wed, Nov 27, 2024 at 05:53:57PM -0800, Andre Muezerie wrote: > > > MSVC issues the warnings below: > > > > > > 1) ../li

Re: [PATCH 2/2] lib/hash: avoid implicit conversion to 64 bit number

2025-01-22 Thread Andre Muezerie
On Wed, Jan 22, 2025 at 04:12:49PM +, Bruce Richardson wrote: > On Wed, Nov 27, 2024 at 05:53:57PM -0800, Andre Muezerie wrote: > > MSVC issues the warnings below: > > > > 1) ../lib/hash/rte_thash_gf2_poly_math.c(128): warning C4334: '<<': > > result of 32-bit shift implicitly converted to

Re: [PATCH 2/2] lib/hash: avoid implicit conversion to 64 bit number

2025-01-22 Thread Bruce Richardson
On Wed, Nov 27, 2024 at 05:53:57PM -0800, Andre Muezerie wrote: > MSVC issues the warnings below: > > 1) ../lib/hash/rte_thash_gf2_poly_math.c(128): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > > The code would be better of

Re: [PATCH 2/2] lib/hash: avoid implicit conversion to 64 bit number

2025-01-22 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 28/11/2024 01:53, Andre Muezerie wrote: MSVC issues the warnings below: 1) ../lib/hash/rte_thash_gf2_poly_math.c(128): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) The code would be better of

[PATCH 2/2] lib/hash: avoid implicit conversion to 64 bit number

2024-11-27 Thread Andre Muezerie
MSVC issues the warnings below: 1) ../lib/hash/rte_thash_gf2_poly_math.c(128): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) The code would be better off by using 64 bit numbers to begin with. That eliminates the need for a conver