Re: [PATCH 2/2] lib: make graph optional

2023-06-22 Thread Thomas Monjalon
20/06/2023 10:20, Jerin Jacob: > On Tue, Jun 20, 2023 at 1:40 PM Bruce Richardson > wrote: > > > > On Mon, Jun 19, 2023 at 10:46:50PM +0200, David Marchand wrote: > > > Allow disabling of the graph library in builds. > > > > > > Signed-off-by: David Marchand > > > --- > > > app/test/meson.build

Re: [PATCH 2/2] lib: make graph optional

2023-06-20 Thread Jerin Jacob
On Tue, Jun 20, 2023 at 1:40 PM Bruce Richardson wrote: > > On Mon, Jun 19, 2023 at 10:46:50PM +0200, David Marchand wrote: > > Allow disabling of the graph library in builds. > > > > Signed-off-by: David Marchand > > --- > > app/test/meson.build | 12 +++- > > lib/meson.build | 1

Re: [PATCH 2/2] lib: make graph optional

2023-06-20 Thread Bruce Richardson
On Mon, Jun 19, 2023 at 10:46:50PM +0200, David Marchand wrote: > Allow disabling of the graph library in builds. > > Signed-off-by: David Marchand > --- > app/test/meson.build | 12 +++- > lib/meson.build | 1 + > 2 files changed, 8 insertions(+), 5 deletions(-) > Acked-by: Bruce

Re: [PATCH 2/2] lib: make graph optional

2023-06-20 Thread David Marchand
On Tue, Jun 20, 2023 at 8:56 AM Jerin Jacob wrote: > > On Tue, Jun 20, 2023 at 2:17 AM David Marchand > wrote: > > > > Allow disabling of the graph library in builds. > > Good to make graph as optional. > I did not check the build, will examples/l3fwd-graph/ skip automatically ? Yes. Each exampl

Re: [PATCH 2/2] lib: make graph optional

2023-06-19 Thread Jerin Jacob
On Tue, Jun 20, 2023 at 2:17 AM David Marchand wrote: > > Allow disabling of the graph library in builds. Good to make graph as optional. I did not check the build, will examples/l3fwd-graph/ skip automatically ? > > Signed-off-by: David Marchand > --- > +if dpdk_conf.has('RTE_LIB_GRAPH') Can

[PATCH 2/2] lib: make graph optional

2023-06-19 Thread David Marchand
Allow disabling of the graph library in builds. Signed-off-by: David Marchand --- app/test/meson.build | 12 +++- lib/meson.build | 1 + 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index 35d6baeb22..c96488126f 100644 --