Re: [PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching

2022-02-14 Thread Martin Spinler
On Mon, 2022-02-14 at 13:36 +, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > In the firmware, the promisc mode overrides the multicast mode. > > So when the promisc mode is turned off, driver must check if the > > multicast mode was act

Re: [PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching

2022-02-14 Thread Ferruh Yigit
On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote: From: Martin Spinler In the firmware, the promisc mode overrides the multicast mode. So when the promisc mode is turned off, driver must check if the multicast mode was active before and conditionally reactivate it. Can you please add fixes & s

[PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching

2022-02-14 Thread spinler
From: Martin Spinler In the firmware, the promisc mode overrides the multicast mode. So when the promisc mode is turned off, driver must check if the multicast mode was active before and conditionally reactivate it. Signed-off-by: Martin Spinler --- drivers/net/nfb/nfb.h| 4 driv