Re: [PATCH v1] net/e1000: do not update link status in secondary process

2024-08-22 Thread Bruce Richardson
On Thu, Aug 22, 2024 at 04:58:59PM +0100, Bruce Richardson wrote: > On Fri, Jul 12, 2024 at 07:30:47PM +0800, Jun Wang wrote: > > The code to update link status is not safe in secondary process. > > If called from secondary it will crash, example from dumpcap: > > eth_em_link_update > > > > Si

Re: [PATCH v1] net/e1000: do not update link status in secondary process

2024-08-22 Thread Bruce Richardson
On Fri, Jul 12, 2024 at 07:30:47PM +0800, Jun Wang wrote: > The code to update link status is not safe in secondary process. > If called from secondary it will crash, example from dumpcap: > eth_em_link_update > > Signed-off-by: Jun Wang > --- > drivers/net/e1000/em_ethdev.c | 3 +++ > 1 fil

Re: [PATCH v1] net/e1000: do not update link status in secondary process

2024-07-22 Thread Jun Wang
I used the e1000 NIC with OVS-DPDK and experienced a failure when using the /dpdk/app/dpdk-dumpcap command to capture packets. After making modifications, it worked fine. /dpdk/app/dpdk-dumpcap -i :00:04.0 File: /tmp/dpdk-dumpcap_0_:00:04.0_20240723020203.pcapng Segmentation fault (core

Re: [PATCH v1] net/e1000: do not update link status in secondary process

2024-07-22 Thread Bruce Richardson
On Sun, Jul 14, 2024 at 04:26:26PM +0800, Jun Wang wrote: >>> The code to update link status is not safe in secondary process. >>> If called from secondary it will crash, example from dumpcap: >>> eth_em_link_update >>> >>> Signed-off-by: Jun Wang >> >> Wouldn't it

Re: [PATCH v1] net/e1000: do not update link status in secondary process

2024-07-14 Thread Jun Wang
>> The code to update link status is not safe in secondary process. >> If called from secondary it will crash, example from dumpcap: >> eth_em_link_update >> >> Signed-off-by: Jun Wang > > Wouldn't it be better to fix the code in e1000_check_link to work in > secondary process. There are netw

[PATCH v1] net/e1000: do not update link status in secondary process

2024-07-12 Thread Jun Wang
The code to update link status is not safe in secondary process. If called from secondary it will crash, example from dumpcap: eth_em_link_update Signed-off-by: Jun Wang --- drivers/net/e1000/em_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/e1000/em_ethdev.c b/d