Re: [PATCH v1 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

2024-06-24 Thread Jeremy Spewock
On Fri, Jun 21, 2024 at 10:14 AM Juraj Linkeš wrote: > > > > +#: Padding to add to the start of a line for python syntax compliance. > > +_padding: ClassVar[str] = " " * 4 > > We use padding in the context of packets so let's use something else > here, such as _python_indentation. I didn'

Re: [PATCH v1 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

2024-06-21 Thread Juraj Linkeš
+#: Padding to add to the start of a line for python syntax compliance. +_padding: ClassVar[str] = " " * 4 We use padding in the context of packets so let's use something else here, such as _python_indentation. + def __init__(self, tg_node: Node, config: ScapyTrafficGenerato

[PATCH v1 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

2024-06-20 Thread jspewock
From: Jeremy Spewock Previously all scapy commands were handled using an XML-RPC server that ran on the TGNode. This unnecessarily enforces a minimum Python version of 3.10 on the server that is being used as a traffic generator and complicates the implementation of scapy methods. This patch remo