Re: [PATCH v10 1/4] hash: pack the hitmask for hash in bulk lookup

2024-07-07 Thread Thomas Monjalon
05/07/2024 19:43, Yoan Picchi: > On 7/4/24 21:31, David Marchand wrote: > > On Wed, Jul 3, 2024 at 7:13 PM Yoan Picchi wrote: > >> --- /dev/null > >> +++ b/lib/hash/compare_signatures_arm_pvt.h > > > > I guess pvt stands for private. > > No need for such suffix, this header won't be exported in a

Re: [PATCH v10 1/4] hash: pack the hitmask for hash in bulk lookup

2024-07-05 Thread Yoan Picchi
I'll push a v11 tonight. There is a couple of comments I disagree with tough: On 7/4/24 21:31, David Marchand wrote: Hello Yoan, On Wed, Jul 3, 2024 at 7:13 PM Yoan Picchi wrote: Current hitmask includes padding due to Intel's SIMD implementation detail. This patch allows non Intel SIMD imp

Re: [PATCH v10 1/4] hash: pack the hitmask for hash in bulk lookup

2024-07-04 Thread David Marchand
Hello Yoan, On Wed, Jul 3, 2024 at 7:13 PM Yoan Picchi wrote: > > Current hitmask includes padding due to Intel's SIMD > implementation detail. This patch allows non Intel SIMD > implementations to benefit from a dense hitmask. > In addition, the new dense hitmask interweave the primary > and sec

[PATCH v10 1/4] hash: pack the hitmask for hash in bulk lookup

2024-07-03 Thread Yoan Picchi
Current hitmask includes padding due to Intel's SIMD implementation detail. This patch allows non Intel SIMD implementations to benefit from a dense hitmask. In addition, the new dense hitmask interweave the primary and secondary matches which allow a better cache usage and enable future improvemen