[PATCH v14] app/procinfo: display eventdev xstats

2023-05-17 Thread Abdullah Sevincer
This commit extends proc-info application to display xstats for the eventdev devices. New command line arguments are introduced to display xstats for eventdev devices. The command example is like: For displaying a specific port stats (e.g. port 1): ./dpdk-proc-info -- --show-edev-port-xstats=1:0

Re: [PATCH v14] app/procinfo: display eventdev xstats

2023-05-17 Thread Stephen Hemminger
On Wed, 17 May 2023 17:37:24 -0500 Abdullah Sevincer wrote: > +static int > +parse_eventdev_dump_xstats_params(char *list) > +{ > + uint8_t evdev_id; > + evdev_id = (uint8_t)atoi(list); > + > + if (evdev_id >= RTE_EVENT_MAX_DEVS) { > + printf("Invalid eventdev id, id shoul

RE: [PATCH v14] app/procinfo: display eventdev xstats

2023-05-17 Thread Sevincer, Abdullah
> +The cast will cause truncation of large values, so this might be a nop. > +If you really want to check, then something like: > + unsigned long evdev_id; > + char *endp; > + evdev_id = strtoul(list, &endp, 0); > + if (!*list || !*endp || evdev_id >= RTE_EVENT_MAX_DEVS) { > +

RE: [PATCH v14] app/procinfo: display eventdev xstats

2023-05-24 Thread Pattan, Reshma
> -Original Message- > From: Sevincer, Abdullah The code looks better now, however if you can make below changes that would be great. > + > +struct eventdev_params { > + uint32_t show_eventdev; Can't we get rid of the "show_eventdev", and just rely below flags > + uint8_