RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-25 Thread Akhil Goyal
> > On 25-Jul-24 5:47 AM, Akhil Goyal wrote: > >> On 24-Jul-24 2:04 PM, Akhil Goyal wrote: > On 24-Jul-24 12:20 PM, Akhil Goyal wrote: > >> On 23-Jul-24 5:57 PM, Akhil Goyal wrote: > Hi all, > > This patch breaks ipsec tests with ipsec-secgw: > > >>

Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-25 Thread Radu Nicolau
> Cc: oss-driv...@corigine.com <mailto:oss- driv...@corigine.com> ; Shihong Wang <mailto:shihong.w...@corigine.com> ; sta...@dpdk.org <mailto:sta...@dpdk.org> Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt

RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-24 Thread Akhil Goyal
t salt[4]" but that > >> implies API changes and it doesn't change how the bytes are stored, so > >> the patch will still be wrong. > >> > >> > >>>>>> On 03/07/2024 18:58, Akhil Goyal wrote: > >>>>>> > &g

Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-24 Thread Radu Nicolau
ine.com <mailto:oss- driv...@corigine.com> ; Shihong Wang <mailto:shihong.w...@corigine.com> ; sta...@dpdk.org <mailto:sta...@dpdk.org> Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem Su

RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-24 Thread Akhil Goyal
gt;> > >>>> > >>>> > >>>> > >>>> > >>>> -Original Message----- > >>>> From: Akhil Goyal > >>>> <mailto:gak...@marvell.com> > >>>> Sent: Friday,

Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-24 Thread Radu Nicolau
.com <mailto:oss- driv...@corigine.com> ; Shihong Wang <mailto:shihong.w...@corigine.com> ; sta...@dpdk.org <mailto:sta...@dpdk.org> Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endiann

RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-24 Thread Akhil Goyal
Goyal > >> <mailto:gak...@marvell.com> ; Chaoyong He > >> > >> <mailto:chaoyong...@corigine.com> ; dev@dpdk.org <mailto:dev@dpdk.org> > >> Cc: oss-driv...@corigine.com <mailto:oss- > >> driv...@corigine.com>

Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-24 Thread Radu Nicolau
shihong.w...@corigine.com> ; sta...@dpdk.org <mailto:sta...@dpdk.org> Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec- secg

RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-23 Thread Akhil Goyal
:dev@dpdk.org> > Cc: oss-driv...@corigine.com <mailto:oss- > driv...@corigine.com> ; Shihong Wang > <mailto:shihong.w...@corigine.com> ; > sta...@dpdk.org <mailto:sta...@dpdk.org> > Subject: RE: [EXTERNAL] [PATCH v2] exa

Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-23 Thread Medvedkin, Vladimir
endianness problem Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem From: Shihong Wang The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s value is stored in an array of encryption or authentication keys according to big-endian. So it maybe need

RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-03 Thread Akhil Goyal
> -Original Message- > From: Akhil Goyal > Sent: Friday, March 15, 2024 12:42 AM > To: Akhil Goyal ; Chaoyong He > ; dev@dpdk.org > Cc: oss-driv...@corigine.com; Shihong Wang ; > sta...@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA s

RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-03-14 Thread Akhil Goyal
> Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt > endianness problem > > > From: Shihong Wang > > > > The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s > > value is stored in an array of encryption or authentication key

RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-03-14 Thread Akhil Goyal
> From: Shihong Wang > > The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s > value is stored in an array of encryption or authentication keys > according to big-endian. So it maybe need to convert the endianness > order to ensure that the value assigned to the SA salt is CPU-e

[PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-03-13 Thread Chaoyong He
From: Shihong Wang The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s value is stored in an array of encryption or authentication keys according to big-endian. So it maybe need to convert the endianness order to ensure that the value assigned to the SA salt is CPU-endian. Fixe