Re: [PATCH v2] net/memif: default to physical socket

2023-02-08 Thread Nathan Skrzypczak
Hi Ferruh, Sorry for the late reply, You can probably drop this patch. Kind regards, -Nathan Le ven. 9 déc. 2022 à 16:13, Ferruh Yigit a écrit : > On 12/8/2022 11:24 AM, Nathan Skrzypczak wrote: > > Hi Stephen, Hi Ferruh, > > > > I don't have a strong opinion on usage of regular sockets vs abs

Re: [PATCH v2] net/memif: default to physical socket

2022-12-12 Thread Nathan Skrzypczak
Hi Stephen, Hi Ferruh, I don't have a strong opinion on usage of regular sockets vs abstract sockets. My point is that most existing memif implementations either don't yet properly support abstract sockets or require extra flags to be passed by users (iirc VPP, gomemif, libmemif, etc...). As a mat

Re: [PATCH v2] net/memif: default to physical socket

2022-12-12 Thread Nathan Skrzypczak
Hi Ferruh, Thank you for your reply, On the potential confusion for users of the DPDK memif PMD : when defaulting to abstract sockets was added in [0] (v20.10 release) it did change the existing behavior, so reverting it would restore the old behavior. Also abstract sockets are quite a unusual fe

Re: [PATCH v2] net/memif: default to physical socket

2022-12-09 Thread Ferruh Yigit
On 12/8/2022 11:24 AM, Nathan Skrzypczak wrote: > Hi Stephen, Hi Ferruh, > > I don't have a strong opinion on usage of regular sockets vs abstract > sockets. My point is that most existing memif implementations > either don't yet properly support abstract sockets or require extra > flags to be pas

Re: [PATCH v2] net/memif: default to physical socket

2022-12-07 Thread Stephen Hemminger
On Wed, 7 Dec 2022 17:15:06 + Ferruh Yigit wrote: > On 12/7/2022 3:56 PM, Nathan Skrzypczak wrote: > > Hi Ferruh, > > > > Hi Nathan, > > > Thank you for your reply,  > > > > On the potential confusion for users of the DPDK memif PMD : when > > defaulting to abstract sockets was added in

Re: [PATCH v2] net/memif: default to physical socket

2022-12-07 Thread Ferruh Yigit
On 12/7/2022 3:56 PM, Nathan Skrzypczak wrote: > Hi Ferruh, > Hi Nathan, > Thank you for your reply,  > > On the potential confusion for users of the DPDK memif PMD : when > defaulting to abstract sockets was added in [0] (v20.10 release) > it did change the existing behavior, so reverting it w

Re: [PATCH v2] net/memif: default to physical socket

2022-12-07 Thread Ferruh Yigit
On 10/17/2022 1:12 PM, Nathan Skrzypczak wrote: > This patch changes the default value of the memif abstract > socket flag to false. The implementation of memif with > abstract sockets made abstract-socket=yes the > default in [0] which might confuse users. > Hi Nathan, OK to update logs to clar

[PATCH v2] net/memif: default to physical socket

2022-10-24 Thread Nathan Skrzypczak
This patch changes the default value of the memif abstract socket flag to false. The implementation of memif with abstract sockets made abstract-socket=yes the default in [0] which might confuse users. This patches makes 'socket-abstract=no' the new default, and adds warnings mentioning the nature