Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-10-09 Thread Ferruh Yigit
On 10/6/2023 7:31 PM, David Christensen wrote: > > > On 9/29/23 6:48 AM, Ferruh Yigit wrote: >> On 6/7/2023 7:47 PM, Ferruh Yigit wrote: >>> On 5/16/2023 10:55 AM, Ferruh Yigit wrote: On 5/16/2023 2:28 AM, Stephen Hemminger wrote: > On Tue, 16 May 2023 00:35:56 +0100 > Ferruh Yigit

Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-10-06 Thread David Christensen
On 9/29/23 6:48 AM, Ferruh Yigit wrote: On 6/7/2023 7:47 PM, Ferruh Yigit wrote: On 5/16/2023 10:55 AM, Ferruh Yigit wrote: On 5/16/2023 2:28 AM, Stephen Hemminger wrote: On Tue, 16 May 2023 00:35:56 +0100 Ferruh Yigit wrote: Yes only some scripts and possible applications that hotplug t

Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-09-29 Thread Ferruh Yigit
On 6/7/2023 7:47 PM, Ferruh Yigit wrote: > On 5/16/2023 10:55 AM, Ferruh Yigit wrote: >> On 5/16/2023 2:28 AM, Stephen Hemminger wrote: >>> On Tue, 16 May 2023 00:35:56 +0100 >>> Ferruh Yigit wrote: >>> Yes only some scripts and possible applications that hotplug tap interface with hardc

Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-06-07 Thread Stephen Hemminger
On Wed, 7 Jun 2023 19:47:04 +0100 Ferruh Yigit wrote: > On 5/16/2023 10:55 AM, Ferruh Yigit wrote: > > On 5/16/2023 2:28 AM, Stephen Hemminger wrote: > >> On Tue, 16 May 2023 00:35:56 +0100 > >> Ferruh Yigit wrote: > >> > >>> Yes only some scripts and possible applications that hotplug tap >

Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-06-07 Thread Ferruh Yigit
On 5/16/2023 10:55 AM, Ferruh Yigit wrote: > On 5/16/2023 2:28 AM, Stephen Hemminger wrote: >> On Tue, 16 May 2023 00:35:56 +0100 >> Ferruh Yigit wrote: >> >>> Yes only some scripts and possible applications that hotplug tap >>> interface with hardcoded parameters may impacted, don't know how big

Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-05-16 Thread Ferruh Yigit
On 5/16/2023 2:28 AM, Stephen Hemminger wrote: > On Tue, 16 May 2023 00:35:56 +0100 > Ferruh Yigit wrote: > >> Yes only some scripts and possible applications that hotplug tap >> interface with hardcoded parameters may impacted, don't know how big is >> this amount but this ends up breaking somet

Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-05-15 Thread Stephen Hemminger
On Tue, 16 May 2023 00:35:56 +0100 Ferruh Yigit wrote: > Yes only some scripts and possible applications that hotplug tap > interface with hardcoded parameters may impacted, don't know how big is > this amount but this ends up breaking something that was working before > upgrading DPDK for them.

Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-05-15 Thread Ferruh Yigit
On 5/16/2023 12:20 AM, Stephen Hemminger wrote: > On Tue, 16 May 2023 00:14:52 +0100 > Ferruh Yigit wrote: > >> Hi David, >> >> I confirm the build error, btw it helps to future references to put >> build failure to the commit log, >> >> and change is reasonable to convert PMD local parse functio

Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-05-15 Thread Stephen Hemminger
On Tue, 16 May 2023 00:14:52 +0100 Ferruh Yigit wrote: > Hi David, > > I confirm the build error, btw it helps to future references to put > build failure to the commit log, > > and change is reasonable to convert PMD local parse function to an API, > BUT my concern is they don't behave exactly

Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-05-15 Thread Ferruh Yigit
On 3/23/2023 5:01 PM, David Christensen wrote: > Building DPDK with gcc 12 on a ppc64le system generates a > stringop-overflow warning. Replace the local MAC address > validation function parse_user_mac() with a call to > rte_ether_unformat_addr() instead. > > Bugzilla ID: 1197 > Cc: sta...@dpdk.o

[PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-03-23 Thread David Christensen
Building DPDK with gcc 12 on a ppc64le system generates a stringop-overflow warning. Replace the local MAC address validation function parse_user_mac() with a call to rte_ether_unformat_addr() instead. Bugzilla ID: 1197 Cc: sta...@dpdk.org Signed-off-by: David Christensen --- v2: * Added NULL ch