Re: [PATCH v2] testpmd: make f_quit flag volatile

2022-11-09 Thread Andrew Rybchenko
On 11/9/22 13:11, Ruifeng Wang wrote: -Original Message- From: Stephen Hemminger Sent: Wednesday, November 9, 2022 2:08 AM To: dev@dpdk.org Cc: Phil Yang ; Stephen Hemminger Subject: [PATCH v2] testpmd: make f_quit flag volatile Since f_quit is set in a signal handler it needs to be

RE: [PATCH v2] testpmd: make f_quit flag volatile

2022-11-09 Thread Ruifeng Wang
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, November 9, 2022 2:08 AM > To: dev@dpdk.org > Cc: Phil Yang ; Stephen Hemminger > > Subject: [PATCH v2] testpmd: make f_quit flag volatile > > Since f_quit is set in a signal handler it

[PATCH v2] testpmd: make f_quit flag volatile

2022-11-08 Thread Stephen Hemminger
Since f_quit is set in a signal handler it needs to be marked volatile. Otherwise, compiler is allowed to optimize the loop because it can assume the value never changes. The flag can also be made local to the file it is used in. Fixes: d9a191a00e81 ("app/testpmd: fix quitting in container") Sign