Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-05-15 Thread David Marchand
On Wed, Jan 4, 2023 at 6:19 AM Nipun Gupta wrote: > At the cleanup time when dma unmap is done, linux kernel > does not allow unmap of individual segments which were > coalesced together while creating the DMA map for type1 IOMMU > mappings. So, this change updates the mapping of the memory > segm

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-05-11 Thread Burakov, Anatoly
On 5/10/2023 1:58 PM, Nipun Gupta wrote: On 4/24/2023 8:52 PM, David Marchand wrote: Hello Anatoly, On Wed, Apr 5, 2023 at 4:17 PM Burakov, Anatoly wrote: Could you please provide some steps to reproduce the hotplug issue you're having? It would be great to have a test case for this patchs

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-05-10 Thread Nipun Gupta
On 4/24/2023 8:52 PM, David Marchand wrote: Hello Anatoly, On Wed, Apr 5, 2023 at 4:17 PM Burakov, Anatoly wrote: Could you please provide some steps to reproduce the hotplug issue you're having? It would be great to have a test case for this patchset to put it in context. I am working o

RE: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-24 Thread Gupta, Nipun
> -Original Message- > From: Stephen Hemminger > Sent: Monday, April 24, 2023 9:41 PM > To: David Marchand > Cc: Burakov, Anatoly ; Gupta, Nipun > ; dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Agarwal, Nikhil > Subject: Re: [PATCH v2] vfio: do n

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-24 Thread Stephen Hemminger
On Mon, 24 Apr 2023 17:22:46 +0200 David Marchand wrote: > > > > > > > Thanks, I can reproduce this issue with regular devices too (run testpmd > > with no devices, bind a NIC to VFIO, attach it, then quit). You're > > correct in that since the initial mapping was done with mapping large > > co

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-24 Thread David Marchand
Hello Anatoly, On Wed, Apr 5, 2023 at 4:17 PM Burakov, Anatoly wrote: > >> Could you please provide some steps to reproduce the hotplug issue > >> you're having? It would be great to have a test case for this patchset > >> to put it in context. > > > > I am working on CDX bus > > (http://patchwor

RE: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-11 Thread Gupta, Nipun
[AMD Official Use Only - General] > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 11, 2023 8:43 PM > To: Burakov, Anatoly ; David Marchand > ; Gupta, Nipun > Cc: dev@dpdk.org; Yigit, Ferruh ; Agarwal, Nikhil > > Subject: Re: [PATCH v2] v

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-11 Thread Thomas Monjalon
04/04/2023 18:32, Nipun Gupta: > On 4/4/2023 8:43 PM, Burakov, Anatoly wrote: > > The patch probably shouldn't include the mailmap changes :) > > Sure, will send a separate patch for it. No please, we squash mailmap changes with 1st patch.

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-07 Thread David Marchand
Hello Nipun, Anatoly, On Fri, Apr 7, 2023 at 8:13 AM Nipun Gupta wrote: > > The patch probably shouldn't include the mailmap changes :) Mailmap changes can be done by the submitter. So Nipun did nothing wrong. > > I see in "git log" that all the mailmap changes are with the patch > submitted, p

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-06 Thread Nipun Gupta
On 4/4/2023 8:43 PM, Burakov, Anatoly wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On 2/7/2023 8:56 AM, Gupta, Nipun wrote: [AMD Official Use Only - General] Hi David, I agree that change is n

RE: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-05 Thread Gupta, Nipun
[AMD Official Use Only - General] > -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, April 5, 2023 7:46 PM > To: Gupta, Nipun ; David Marchand > > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Agarwal, Nikhil > Subject: Re: [PATCH v

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-05 Thread Burakov, Anatoly
On 4/4/2023 5:32 PM, Nipun Gupta wrote: On 4/4/2023 8:43 PM, Burakov, Anatoly wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On 2/7/2023 8:56 AM, Gupta, Nipun wrote: [AMD Official Use Only - Gener

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-04 Thread Nipun Gupta
On 4/4/2023 8:43 PM, Burakov, Anatoly wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On 2/7/2023 8:56 AM, Gupta, Nipun wrote: [AMD Official Use Only - General] Hi David, I agree that change is n

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-04 Thread Burakov, Anatoly
On 2/7/2023 8:56 AM, Gupta, Nipun wrote: [AMD Official Use Only - General] Hi David, I agree that change is not straightforward to review, but it should not cause any functional issue as we are still creating all the memory mappings, but one by one for each segment. For hot plug case this cau

RE: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-04 Thread Gupta, Nipun
onjalon.net; Yigit, Ferruh > ; Agarwal, Nikhil > Subject: RE: [PATCH v2] vfio: do not coalesce DMA mappings > > [AMD Official Use Only - General] > > Hi David, > > I agree that change is not straightforward to review, but it should not cause > any > functional issue

RE: [PATCH v2] vfio: do not coalesce DMA mappings

2023-02-07 Thread Gupta, Nipun
nal Message- > From: David Marchand > Sent: Thursday, February 2, 2023 4:19 PM > To: anatoly.bura...@intel.com; Gupta, Nipun > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Agarwal, Nikhil > Subject: Re: [PATCH v2] vfio: do not coalesce DMA mappings > > Caution: T

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-02-02 Thread David Marchand
Hi, On Wed, Jan 4, 2023 at 6:19 AM Nipun Gupta wrote: > > At the cleanup time when dma unmap is done, linux kernel > does not allow unmap of individual segments which were > coalesced together while creating the DMA map for type1 IOMMU > mappings. So, this change updates the mapping of the memory

[PATCH v2] vfio: do not coalesce DMA mappings

2023-01-03 Thread Nipun Gupta
At the cleanup time when dma unmap is done, linux kernel does not allow unmap of individual segments which were coalesced together while creating the DMA map for type1 IOMMU mappings. So, this change updates the mapping of the memory segments(hugepages) on a per-page basis. Signed-off-by: Nipun Gu