Re: [PATCH v2 1/2] cmdline: add function to verify valid commands

On Fri, Jun 10, 2022 at 03:08:49PM +0100, Bruce Richardson wrote: > On Tue, Jun 07, 2022 at 10:08:30AM +0200, Olivier Matz wrote: > > Hi Bruce, > > > > Just few minor comments below. > > > > On Fri, May 20, 2022 at 04:12:39PM +0100, Bruce Richardson wrote: > > > The cmdline library cmdline_parse(

Re: [PATCH v2 1/2] cmdline: add function to verify valid commands

On Tue, Jun 07, 2022 at 10:08:30AM +0200, Olivier Matz wrote: > Hi Bruce, > > Just few minor comments below. > > On Fri, May 20, 2022 at 04:12:39PM +0100, Bruce Richardson wrote: > > The cmdline library cmdline_parse() function parses a command and > > executes the action automatically too. The c

Re: [PATCH v2 1/2] cmdline: add function to verify valid commands

Hi Bruce, Just few minor comments below. On Fri, May 20, 2022 at 04:12:39PM +0100, Bruce Richardson wrote: > The cmdline library cmdline_parse() function parses a command and > executes the action automatically too. The cmdline_valid_buffer function > also uses this function to validate commands,

RE: [PATCH v2 1/2] cmdline: add function to verify valid commands

> -Original Message- > From: Richardson, Bruce > Sent: Friday, May 20, 2022 11:13 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Li, WeiyuanX ; Richardson, > Bruce ; Olivier Matz > ; Ray Kinsella > Subject: [PATCH v2 1/2] cmdline: add function to verify valid c

[PATCH v2 1/2] cmdline: add function to verify valid commands

The cmdline library cmdline_parse() function parses a command and executes the action automatically too. The cmdline_valid_buffer function also uses this function to validate commands, meaning that there is no function to validate a command as ok without executing it. To fix this omission, we extr