Re: [PATCH v2 1/3] app/testpmd: add register keyword

2024-10-03 Thread Ferruh Yigit
On 9/6/2024 2:02 PM, Varghese, Vipin wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > >   >> > > >> --- a/app/test-pmd/macswap_sse.h >> > > >> +++ b/app/test-pmd/macswap_sse.h >> > > >> @@ -16,13 +16,13 @@ do_macswap(struct rte_mbuf *pkts[], uint16_t >> nb, >> > > >>    u

RE: [PATCH v2 1/3] app/testpmd: add register keyword

2024-09-06 Thread Varghese, Vipin
[AMD Official Use Only - AMD Internal Distribution Only] > > > >> --- a/app/test-pmd/macswap_sse.h > > > >> +++ b/app/test-pmd/macswap_sse.h > > > >> @@ -16,13 +16,13 @@ do_macswap(struct rte_mbuf *pkts[], uint16_t > nb, > > > >>uint64_t ol_flags; > > > >>int i; > > > >>

RE: [PATCH v2 1/3] app/testpmd: add register keyword

2024-09-03 Thread Konstantin Ananyev
> > > > > >> diff --git a/app/test-pmd/macswap_sse.h b/app/test-pmd/macswap_sse.h > > >> index 223f87a539..29088843b7 100644 > > >> --- a/app/test-pmd/macswap_sse.h > > >> +++ b/app/test-pmd/macswap_sse.h > > >> @@ -16,13 +16,13 @@ do_macswap(struct rte_mbuf *pkts[], uint16_t nb, > > >>u

Re: [PATCH v2 1/3] app/testpmd: add register keyword

2024-08-29 Thread Varghese, Vipin
On 8/27/2024 11:09 PM, Stephen Hemminger wrote: not sure why compiler would not decide to already use a register here? Hi Stephen, I totally agree with your point, but in practice it did not use registers for code generation.

Re: [PATCH v2 1/3] app/testpmd: add register keyword

2024-08-27 Thread Stephen Hemminger
On Tue, 27 Aug 2024 21:02:00 +0530 "Varghese, Vipin" wrote: > On 8/21/2024 8:25 PM, Stephen Hemminger wrote: > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > On Wed, 21 Aug 2024 20:08:55 +053

Re: [PATCH v2 1/3] app/testpmd: add register keyword

2024-08-27 Thread Varghese, Vipin
On 8/21/2024 8:25 PM, Stephen Hemminger wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Wed, 21 Aug 2024 20:08:55 +0530 Vipin Varghese wrote: diff --git a/app/test-pmd/macswap_sse.h b/app/test-p

Re: [PATCH v2 1/3] app/testpmd: add register keyword

2024-08-21 Thread Stephen Hemminger
On Wed, 21 Aug 2024 20:08:55 +0530 Vipin Varghese wrote: > diff --git a/app/test-pmd/macswap_sse.h b/app/test-pmd/macswap_sse.h > index 223f87a539..29088843b7 100644 > --- a/app/test-pmd/macswap_sse.h > +++ b/app/test-pmd/macswap_sse.h > @@ -16,13 +16,13 @@ do_macswap(struct rte_mbuf *pkts[], uin

[PATCH v2 1/3] app/testpmd: add register keyword

2024-08-21 Thread Vipin Varghese
Currently SSE SIMD variables are declared as stack variables. Allowing the use of keyword register for shuffle mask and address variables, improves the mac-swap Mpps by 1 for single queue. Test Result: * Platform: AMD EPYC 9554 @3.1GHz, no boost * Test scenarios: TEST-PMD 64B IO vs MAC-SWAP * N