Re: [PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-22 Thread Dean Marx
Reviewed-by: Dean Marx On Tue, Jul 2, 2024 at 3:25 PM Nicholas Pratte wrote: > Various test cases in the mac filter test suite called for granular > manipulation of destination mac addresses to properly test mac address > filtering functionality. To compensate, there is now an > adjust_addresse

Re: [PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-19 Thread Jeremy Spewock
On Thu, Jul 11, 2024 at 3:31 PM Jeremy Spewock wrote: > > I think this change makes sense, and I mentioned this on Dean's patch > that has the same change in it but I think we should have more > discussion about which route to take with this addressing problem. It > is definitely something that we

Re: [PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-17 Thread Nicholas Pratte
> It might also be worth naming what the default is in the doc-string > (by which I mean that the parameter defaults to True, not the default > address scheme). I can fix that.

Re: [PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-11 Thread Jeremy Spewock
I think this change makes sense, and I mentioned this on Dean's patch that has the same change in it but I think we should have more discussion about which route to take with this addressing problem. It is definitely something that we have to address since it is required for a suite like this or an

[PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-02 Thread Nicholas Pratte
Various test cases in the mac filter test suite called for granular manipulation of destination mac addresses to properly test mac address filtering functionality. To compensate, there is now an adjust_addresses boolean which the user can toggle if they wish to send their own addressing; the boolea

[PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-02 Thread Nicholas Pratte
Various test cases in the mac filter test suite called for granular manipulation of destination mac addresses to properly test mac address filtering functionality. To compensate, there is now an adjust_addresses boolean which the user can toggle if they wish to send their own addressing; the boolea

[PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-02 Thread Nicholas Pratte
Various test cases in the mac filter test suite called for granular manipulation of destination mac addresses to properly test mac address filtering functionality. To compensate, there is now an adjust_addresses boolean which the user can toggle if they wish to send their own addressing; the boolea

[PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-02 Thread Nicholas Pratte
Various test cases in the mac filter test suite called for granular manipulation of destination mac addresses to properly test mac address filtering functionality. To compensate, there is now an adjust_addresses boolean which the user can toggle if they wish to send their own addressing; the boolea

[PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-02 Thread Nicholas Pratte
Various test cases in the mac filter test suite called for granular manipulation of destination mac addresses to properly test mac address filtering functionality. To compensate, there is now an adjust_addresses boolean which the user can toggle if they wish to send their own addressing; the boolea