RE: [EXT] [PATCH v2 2/9] trace: fix mode change

2022-10-12 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Tuesday, October 4, 2022 3:14 PM > To: dev@dpdk.org > Cc: sk...@mavell.com; Jerin Jacob Kollanukkaran ; > sta...@dpdk.org; Sunil Kumar Kori > Subject: [EXT] [PATCH v2 2/9] trace: fix mode chang

Re: [PATCH v2 2/9] trace: fix mode change

2022-10-11 Thread Jerin Jacob
On Tue, Oct 4, 2022 at 3:15 PM David Marchand wrote: > > The API does not state that changing mode should be refused if no trace > point is enabled. Remove this limitation. > > Fixes: 84c4fae4628f ("trace: implement operation APIs") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- >

[PATCH v2 2/9] trace: fix mode change

2022-10-04 Thread David Marchand
The API does not state that changing mode should be refused if no trace point is enabled. Remove this limitation. Fixes: 84c4fae4628f ("trace: implement operation APIs") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test/test_trace.c | 3 --- lib/eal/common/eal_common_tr