RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-02-09 Thread Wang, Haiyue
gt; To: Daly, Jeff ; Wang, Haiyue > >> ; Stephen Douthit > >> ; Morten Brørup ; > >> Lu, Wenzhuo > >> ; Zhang, Helin ; Zhang, Qi Z > >> > >> Cc: dev@dpdk.org; Wang, Wen ; sta...@dpdk.org > >> Subject: Re: [PATCH v2 3/7] net/ixgbe: Ch

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-02-09 Thread Ferruh Yigit
: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write On 2/8/2022 1:50 PM, Jeff Daly wrote: moved response down, please don't top post. -Original Message- From: Ferruh Yigit Sent: Monday, February 7, 2022 11:04 AM To: Wang, Haiyue ; Stephen Do

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-02-08 Thread Wang, Haiyue
gt; Sent: Monday, February 7, 2022 11:04 AM > > To: Wang, Haiyue ; Stephen Douthit > > ; Morten Brørup > ; Lu, Wenzhuo ; Zhang, > Helin ; > Zhang, Qi Z > > Cc: dev@dpdk.org; Wen Wang ; sta...@dpdk.org > > Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 sof

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-02-08 Thread Ferruh Yigit
Wang ; sta...@dpdk.org Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write Caution: This is an external email. Please take care when clicking links or opening attachments. On 1/19/2022 12:31 AM, Wang, Haiyue wrote: -Original Message-

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-02-08 Thread Jeff Daly
04 AM To: Wang, Haiyue ; Stephen Douthit ; Morten Brørup ; Lu, Wenzhuo ; Zhang, Helin ; Zhang, Qi Z Cc: dev@dpdk.org; Wen Wang ; sta...@dpdk.org Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write Caution: This is an external email. Please take

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-02-07 Thread Ferruh Yigit
: Check that SFF-8472 soft rate select is supported before write On 12/22/21 19:55, Wang, Haiyue wrote: OK, let's see in 2022, happy holidays. ;-) A bit of a slower start to 2022 than I had hoped, but I have a v3 of the hotplug fix in progress. It's now working for the 82599 and C

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-01-18 Thread Wang, Haiyue
> -Original Message- > From: Stephen Douthit > Sent: Wednesday, January 19, 2022 05:06 > To: Wang, Haiyue ; Morten Brørup > ; Lu, Wenzhuo > ; Zhang, Helin ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wang, Wen ; sta...@dpdk.org > Subject: Re: [PATCH v2 3/7] net/ixgb

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-01-18 Thread Stephen Douthit
On 12/22/21 19:55, Wang, Haiyue wrote: OK, let's see in 2022, happy holidays. ;-) A bit of a slower start to 2022 than I had hoped, but I have a v3 of the hotplug fix in progress. It's now working for the 82599 and C3000 ixgbe devices under Linux, and I'm in the process of getting this built a

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-22 Thread Wang, Haiyue
> -Original Message- > From: Stephen Douthit > Sent: Thursday, December 23, 2021 05:44 > To: Wang, Haiyue ; Morten Brørup > ; Lu, Wenzhuo > ; Zhang, Helin ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wang, Wen ; sta...@dpdk.org > Subject: Re: [PATCH v2 3/7] net/ixgb

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-22 Thread Stephen Douthit
From Steve's response: ME: "I guess this is just in C3000 reference board SDK ?" Steve: "It's the board covered by Intel Doc # 574437." I check the doc "Last Updated: 11/07/2018" It should be some kind of customer release, that's why they are not in the official *open source*

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-22 Thread Morten Brørup
> From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > Sent: Wednesday, 22 December 2021 17.03 > > > -Original Message- > > From: Morten Brørup > > Sent: Wednesday, December 22, 2021 18:44 > > > > > From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > > > Sent: Wednesday, 22 December 2021 0

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-22 Thread Wang, Haiyue
> -Original Message- > From: Morten Brørup > Sent: Wednesday, December 22, 2021 18:44 > To: Wang, Haiyue ; steph...@silicom-usa.com; Lu, > Wenzhuo ; > Zhang, Helin ; Zhang, Qi Z > Cc: dev@dpdk.org; Wang, Wen ; sta...@dpdk.org > Subject: RE: [PATCH v2 3/7] net/ix

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-22 Thread Morten Brørup
> From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > Sent: Wednesday, 22 December 2021 02.24 > > > -Original Message- > > From: Morten Brørup > > Sent: Tuesday, December 21, 2021 16:58 > > > > > From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > > > Sent: Tuesday, 21 December 2021 02.15

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-21 Thread Wang, Haiyue
> -Original Message- > From: Morten Brørup > Sent: Tuesday, December 21, 2021 16:58 > To: Wang, Haiyue ; steph...@silicom-usa.com; Lu, > Wenzhuo ; > Changchun Ouyang ; Zhang, Helin > > Cc: dev@dpdk.org; Wang, Wen ; sta...@dpdk.org > Subject: RE: [PATCH v2 3/7

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-21 Thread Stephen Douthit
...@dpdk.org Subject: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write Make sure an SFP is really a SFF-8472 device that supports the optional soft rate select feature before just blindly poking those I2C registers. Skip all I2C traffic if we know there's n

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-21 Thread Morten Brørup
> From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > Sent: Tuesday, 21 December 2021 02.15 > > > -Original Message- > > From: Stephen Douthit > > Sent: Tuesday, December 21, 2021 05:33 > > > > On 12/20/21 02:53, Wang, Haiyue wrote: > > >> -Original Message- > > >> From: Stephen D

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-20 Thread Wang, Haiyue
hangchun Ouyang > >> ; Zhang, Helin > >> Cc: dev@dpdk.org; Wen Wang ; Stephen Douthit > >> ; > >> sta...@dpdk.org > >> Subject: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is > >> supported before write > >> > >>

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-20 Thread Stephen Douthit
: Check that SFF-8472 soft rate select is supported before write Make sure an SFP is really a SFF-8472 device that supports the optional soft rate select feature before just blindly poking those I2C registers. Skip all I2C traffic if we know there's no SFP. Fixes: f3430431aba ("ixgbe/bas

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-19 Thread Wang, Haiyue
> -Original Message- > From: Stephen Douthit > Sent: Tuesday, December 7, 2021 06:19 > To: Wang, Haiyue ; Lu, Wenzhuo ; > Changchun Ouyang > ; Zhang, Helin > Cc: dev@dpdk.org; Wen Wang ; Stephen Douthit > ; > sta...@dpdk.org > Subject: [PATCH v2 3/7] net/i

[PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-06 Thread Stephen Douthit
Make sure an SFP is really a SFF-8472 device that supports the optional soft rate select feature before just blindly poking those I2C registers. Skip all I2C traffic if we know there's no SFP. Fixes: f3430431aba ("ixgbe/base: add SFP+ dual-speed support") Cc: sta...@dpdk.org Signed-off-by: Steph