Re: [PATCH v2 5/8] dts: add testpmd shell params

2024-05-29 Thread Jeremy Spewock
On Wed, May 29, 2024 at 11:59 AM Luca Vizzarro wrote: > > On 28/05/2024 22:05, Jeremy Spewock wrote: > > This looks good, the only comment I had was in some classes the > > docstrings didn't get updated to what was discussed previously in the > > comments (making sure the comments are included in

Re: [PATCH v2 5/8] dts: add testpmd shell params

2024-05-29 Thread Luca Vizzarro
On 28/05/2024 22:05, Jeremy Spewock wrote: This looks good, the only comment I had was in some classes the docstrings didn't get updated to what was discussed previously in the comments (making sure the comments are included in the class' docstring). I tried to point out a few places where I noti

Re: [PATCH v2 5/8] dts: add testpmd shell params

2024-05-28 Thread Jeremy Spewock
This looks good, the only comment I had was in some classes the docstrings didn't get updated to what was discussed previously in the comments (making sure the comments are included in the class' docstring). I tried to point out a few places where I noticed it. Other than those comments however: R

Re: [PATCH v2 5/8] dts: add testpmd shell params

2024-05-28 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro wrote: > > Implement all the testpmd shell parameters into a data structure. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > --- > dts/framework/params/testpmd.py

[PATCH v2 5/8] dts: add testpmd shell params

2024-05-09 Thread Luca Vizzarro
Implement all the testpmd shell parameters into a data structure. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/params/testpmd.py | 608 ++ dts/framework/remote_session/testpmd_shell.py | 42 +- dts/tests/TestSuite_pmd_buffer_scatter.