Re: [PATCH v3] doc: add new driver guidelines

2024-09-13 Thread Stephen Hemminger
On Fri, 13 Sep 2024 10:07:26 +0100 Ferruh Yigit wrote: > > 4. If a distribution does not include > the dependency, I redistribute > it with the dependency and open source, > > this is somewhat similar to mlnx_ofed, is it publicly or freely? > > > > All looks good from DPDK perspective, alth

Re: [PATCH v3] doc: add new driver guidelines

2024-09-13 Thread Ferruh Yigit
On 9/13/2024 5:19 AM, WanRenyong wrote: > On 2024/9/13 4:26, Stephen Hemminger wrote >> + >> +Finalizing >> +-- >> + >> +Once the driver has been upstreamed, the author has >> +a responsibility to the community to maintain it. >> + >> +This includes the public test report. Authors must send

Re: [PATCH v3] doc: add new driver guidelines

2024-09-12 Thread WanRenyong
On 2024/9/13 4:26, Stephen Hemminger wrote > + > +Finalizing > +-- > + > +Once the driver has been upstreamed, the author has > +a responsibility to the community to maintain it. > + > +This includes the public test report. Authors must send a public > +test report after the first upstreami

[PATCH v3] doc: add new driver guidelines

2024-09-12 Thread Stephen Hemminger
From: Nandini Persad This document was created to assist contributors in creating DPDK drivers and provides suggestions and guidelines on how to upstream effectively. Co-authored-by: Ferruh Yigit Co-authored-by: Thomas Monjalon Signed-off-by: Nandini Persad Reviewed-by: Stephen Hemminger ---

Re: [PATCH v3] doc: add new driver guidelines

2024-09-12 Thread Nandini Persad
Excellent. Will send the update in accordingly. From: Ferruh Yigit Sent: Thursday, September 12, 2024 6:37:35 AM To: Nandini Persad Cc: dev@dpdk.org ; Thomas Mojalon ; Stephen Hemminger Subject: Re: [PATCH v3] doc: add new driver guidelines On 9/12/2024 2:18

Re: [PATCH v3] doc: add new driver guidelines

2024-09-12 Thread Ferruh Yigit
o with whatever you think more convenient. > > *From:* Ferruh Yigit > *Sent:* Thursday, September 12, 2024 1:13:33 AM > *To:* Nandini Persad > *Cc:* dev@dpdk.org ; Thomas Mojalon ; > Stephen Hemminger > *Subject:* Re: [PATCH v3] doc: add new driver guid

Re: [PATCH v3] doc: add new driver guidelines

2024-09-12 Thread Nandini Persad
just say “Avoid”. From: Ferruh Yigit Sent: Thursday, September 12, 2024 1:13:33 AM To: Nandini Persad Cc: dev@dpdk.org ; Thomas Mojalon ; Stephen Hemminger Subject: Re: [PATCH v3] doc: add new driver guidelines On 9/11/2024 5:04 PM, Nandini Persad wrote: >

Re: [PATCH v3] doc: add new driver guidelines

2024-09-12 Thread Ferruh Yigit
On 9/11/2024 5:04 PM, Nandini Persad wrote: > Hi Ferruh, > > I will work with Stephen on this. For the tone of the list, I believe we > can try different ways to make the tone more friendly, while still being > concise. > > What about something like this: > # Avoid including unused headers (proce

Re: [PATCH v3] doc: add new driver guidelines

2024-09-11 Thread Nandini Persad
Hi Ferruh, I will work with Stephen on this. For the tone of the list, I believe we can try different ways to make the tone more friendly, while still being concise. What about something like this: - Avoid including unused headers (process-iwyu.py). - Keep compiler warnings enabled in the build f

Re: [PATCH v3] doc: add new driver guidelines

2024-09-10 Thread Ferruh Yigit
On 9/10/2024 3:58 PM, Nandini Persad wrote: > This document was created to assist contributors > in creating DPDK drivers, providing suggestions > and guidelines for how to upstream effectively. > There are minor differences in this v3 and v2, isn't this version on top of v2, can those changes be

[PATCH v3] doc: add new driver guidelines

2024-09-10 Thread Nandini Persad
This document was created to assist contributors in creating DPDK drivers, providing suggestions and guidelines for how to upstream effectively. Co-authored-by: Ferruh Yigit Co-authored-by: Thomas Mojalon Signed-off-by: Nandini Persad Acked-by: Chengwen Feng --- doc/guides/contributing/new_dr