Re:RE: [PATCH v3] ip_frag: add IPv4 options fragment and test data

2022-02-28 Thread Huichao Cai
Hi Konstantin, > These macros are dups for what we have in rte_ipv4_fragmentation.c > Would probably make sense to name them RTE_IPV4_IPOPT_... and put them > in some public .h to avoid duplication. I named them RTE_IPV4_IPOPT_xxx and put them in "rte_ip_frag.h". > Could you clarify what this ma

RE: [PATCH v3] ip_frag: add IPv4 options fragment and test data

2022-02-25 Thread Ananyev, Konstantin
Ho Huichao, > According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to deal with it during the > fragmenting pro

[PATCH v3] ip_frag: add IPv4 options fragment and test data

2022-02-20 Thread Huichao Cai
According to RFC791,the options may appear or not in datagrams. They must be implemented by all IP modules (host and gateways). What is optional is their transmission in any particular datagram, not their implementation.So we have to deal with it during the fragmenting process.Add some test data fo