In the methods you added here, you made all of the parameters to them
optional with a default. This might make sense to allow developers to
be less verbose when calling the method with the defaults, but in the
case of things like the port ID, vlan IDs, and things of that nature I
think making these
On Fri, Jun 14, 2024 at 4:29 PM Jeremy Spewock wrote:
> > I wonder whether, when convenient, we want to name the methods more or
> > less 1:1 according to the actual testpmd text command they send? I.e.
> > in this case should the method be named vlan_set_filter_on instead of
> > vlan_filter_set_
On Fri, Jun 14, 2024 at 12:00 PM Patrick Robb wrote:
>
> On Fri, Jun 14, 2024 at 11:03 AM Dean Marx wrote:
> > +def vlan_filter_set_on(self, port: int = 0, verify: bool = True):
> > +"""Set vlan filter on.
> > +
> > +Args:
> > +port: The port number to use, should
On Fri, Jun 14, 2024 at 11:03 AM Dean Marx wrote:
> +def vlan_filter_set_on(self, port: int = 0, verify: bool = True):
> +"""Set vlan filter on.
> +
> +Args:
> +port: The port number to use, should be within 0-32.
> +verify: If :data:`True`, the output o
The testpmd_shell class is intended for sending commands to
a remote testpmd session within a test suite, and as of right now
it is missing most commands. Added commands for vlan filtering,
stripping, and insertion, as well as stopping and starting ports
during testpmd runtime.
Signed-off-by:
5 matches
Mail list logo
