RE: [PATCH v3 1/5] event/opdl: fix non-constant compile time assertion

2024-01-17 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 17 January 2024 10.27 > > On Wed, Jan 17, 2024 at 10:58:12AM +0300, Andrew Rybchenko wrote: > > On 1/16/24 21:41, Stephen Hemminger wrote: > > > RTE_BUILD_BUG_ON() was being used with a non-constant value. > > > The in

Re: [PATCH v3 1/5] event/opdl: fix non-constant compile time assertion

2024-01-17 Thread Bruce Richardson
On Wed, Jan 17, 2024 at 10:58:12AM +0300, Andrew Rybchenko wrote: > On 1/16/24 21:41, Stephen Hemminger wrote: > > RTE_BUILD_BUG_ON() was being used with a non-constant value. > > The inline function rte_is_power_of_2() is not constant since > > inline expansion happens later in the compile process

Re: [PATCH v3 1/5] event/opdl: fix non-constant compile time assertion

2024-01-16 Thread Andrew Rybchenko
On 1/16/24 21:41, Stephen Hemminger wrote: RTE_BUILD_BUG_ON() was being used with a non-constant value. The inline function rte_is_power_of_2() is not constant since inline expansion happens later in the compile process. Replace it with macro which will be constant. Fixes: 4236ce9bf5bf ("event/o

[PATCH v3 1/5] event/opdl: fix non-constant compile time assertion

2024-01-16 Thread Stephen Hemminger
RTE_BUILD_BUG_ON() was being used with a non-constant value. The inline function rte_is_power_of_2() is not constant since inline expansion happens later in the compile process. Replace it with macro which will be constant. Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library") C