Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-25 Thread Jie Hai
On 2024/2/20 23:14, Stephen Hemminger wrote: On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: @@ -20,6 +25,12 @@ struct rte_dev_reg_info { uint32_t length; /**< Number of registers to fetch */ uint32_t width; /**< Size of device register */ uint32_t version; /**< Devic

Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-25 Thread Jie Hai
On 2024/2/20 23:13, Stephen Hemminger wrote: On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: This patch adds "filter" and "names" fields to "rte_dev_reg_info" structure. Names of registers in data fields can be reported and the registers can be filtered by their names. The new API rte_eth_d

Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-25 Thread Jie Hai
On 2024/2/20 23:14, Stephen Hemminger wrote: On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: int rte_eth_dev_get_reg_info(uint16_t port_id, struct rte_dev_reg_info *info) +{ + struct rte_dev_reg_info reg_info = { 0 }; + int ret; + + if (info == NULL) { + R

Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-25 Thread Jie Hai
On 2024/2/20 23:09, Stephen Hemminger wrote: On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: +* **Added support for dumping regiters with names and filter.** Spelling . Hi, Stephen, Thanks for your review. Will fix in V4. Best Regards, Jie Hai

Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-20 Thread Stephen Hemminger
On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: > int > rte_eth_dev_get_reg_info(uint16_t port_id, struct rte_dev_reg_info *info) > +{ > + struct rte_dev_reg_info reg_info = { 0 }; > + int ret; > + > + if (info == NULL) { > + RTE_ETHDEV_LOG_LINE(ERR, > +

Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-20 Thread Stephen Hemminger
On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: > @@ -20,6 +25,12 @@ struct rte_dev_reg_info { > uint32_t length; /**< Number of registers to fetch */ > uint32_t width; /**< Size of device register */ > uint32_t version; /**< Device version */ > + /** > + * Filter for

Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-20 Thread Stephen Hemminger
On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: > This patch adds "filter" and "names" fields to "rte_dev_reg_info" > structure. Names of registers in data fields can be reported and > the registers can be filtered by their names. > > The new API rte_eth_dev_get_reg_info_ext() is added to supp

Re: [PATCH v3 1/7] ethdev: support report register names and filter

2024-02-20 Thread Stephen Hemminger
On Tue, 20 Feb 2024 18:58:17 +0800 Jie Hai wrote: > +* **Added support for dumping regiters with names and filter.** Spelling

[PATCH v3 1/7] ethdev: support report register names and filter

2024-02-20 Thread Jie Hai
This patch adds "filter" and "names" fields to "rte_dev_reg_info" structure. Names of registers in data fields can be reported and the registers can be filtered by their names. The new API rte_eth_dev_get_reg_info_ext() is added to support reporting names and filtering by names. And the original A