Re: [PATCH v3 11/11] telemetry: avoid expanding versioned symbol macros on msvc

2023-04-12 Thread Bruce Richardson
On Tue, Apr 11, 2023 at 01:34:14PM -0700, Tyler Retzlaff wrote: > On Tue, Apr 11, 2023 at 11:24:07AM +0100, Bruce Richardson wrote: > > On Wed, Apr 05, 2023 at 05:45:19PM -0700, Tyler Retzlaff wrote: > > > Windows does not support versioned symbols. Fortunately Windows also > > > doesn't have an ex

Re: [PATCH v3 11/11] telemetry: avoid expanding versioned symbol macros on msvc

2023-04-11 Thread Tyler Retzlaff
On Tue, Apr 11, 2023 at 11:24:07AM +0100, Bruce Richardson wrote: > On Wed, Apr 05, 2023 at 05:45:19PM -0700, Tyler Retzlaff wrote: > > Windows does not support versioned symbols. Fortunately Windows also > > doesn't have an exported stable ABI. > > > > Export rte_tel_data_add_array_int -> rte_tel

Re: [PATCH v3 11/11] telemetry: avoid expanding versioned symbol macros on msvc

2023-04-11 Thread Bruce Richardson
On Wed, Apr 05, 2023 at 05:45:19PM -0700, Tyler Retzlaff wrote: > Windows does not support versioned symbols. Fortunately Windows also > doesn't have an exported stable ABI. > > Export rte_tel_data_add_array_int -> rte_tel_data_add_array_int_24 > and rte_tel_data_add_dict_int -> rte_tel_data_add_d

[PATCH v3 11/11] telemetry: avoid expanding versioned symbol macros on msvc

2023-04-05 Thread Tyler Retzlaff
Windows does not support versioned symbols. Fortunately Windows also doesn't have an exported stable ABI. Export rte_tel_data_add_array_int -> rte_tel_data_add_array_int_24 and rte_tel_data_add_dict_int -> rte_tel_data_add_dict_int_v24 functions. Windows does have a way to achieve similar version