RE: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-25 Thread Akhil Goyal
> 23/10/2024 21:14, Akhil Goyal: > > > 22/10/2024 14:06, Akhil Goyal: > > > > > On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal > wrote: > > > > > > > The rational to NOT pull "Hardware abstraction library using the > > > > > > > BAR > > > > > > > address" to DPDK are > > > > > > > -Yet another 200K

Re: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-23 Thread Thomas Monjalon
23/10/2024 21:14, Akhil Goyal: > > 22/10/2024 14:06, Akhil Goyal: > > > > On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal wrote: > > > > > > The rational to NOT pull "Hardware abstraction library using the BAR > > > > > > address" to DPDK are > > > > > > -Yet another 200K of driver C++ code which does

RE: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-23 Thread Akhil Goyal
> 22/10/2024 14:06, Akhil Goyal: > > > On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal wrote: > > > > > The rational to NOT pull "Hardware abstraction library using the BAR > > > > > address" to DPDK are > > > > > -Yet another 200K of driver C++ code which does not make sense to keep > > > > > in dpdk

Re: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-23 Thread Thomas Monjalon
22/10/2024 14:06, Akhil Goyal: > > On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal wrote: > > > > The rational to NOT pull "Hardware abstraction library using the BAR > > > > address" to DPDK are > > > > -Yet another 200K of driver C++ code which does not make sense to keep > > > > in dpdk.org > > > >

Re: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-22 Thread Jerin Jacob
On Tue, Oct 22, 2024 at 9:00 PM Stephen Hemminger wrote: > > On Tue, 22 Oct 2024 12:08:22 +0200 > David Marchand wrote: > > > On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal wrote: > > > > The rational to NOT pull "Hardware abstraction library using the BAR > > > > address" to DPDK are > > > > -Yet

Re: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-22 Thread Stephen Hemminger
On Tue, 22 Oct 2024 12:08:22 +0200 David Marchand wrote: > On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal wrote: > > > The rational to NOT pull "Hardware abstraction library using the BAR > > > address" to DPDK are > > > -Yet another 200K of driver C++ code which does not make sense to keep > > > i

RE: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-22 Thread Akhil Goyal
> On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal wrote: > > > The rational to NOT pull "Hardware abstraction library using the BAR > > > address" to DPDK are > > > -Yet another 200K of driver C++ code which does not make sense to keep > > > in dpdk.org > > > -It can not implemenent any of the current

Re: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-22 Thread David Marchand
On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal wrote: > > The rational to NOT pull "Hardware abstraction library using the BAR > > address" to DPDK are > > -Yet another 200K of driver C++ code which does not make sense to keep > > in dpdk.org > > -It can not implemenent any of the current subsystems

Re: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-22 Thread Thomas Monjalon
22/10/2024 08:05, Akhil Goyal: > > On Tue, Oct 22, 2024 at 3:00 AM Thomas Monjalon > > wrote: > > > > > > 08/10/2024 20:49, Akhil Goyal: > > > > Added rte_pmd_rvu_lf_bar_get() API to get BAR address > > > > for application to configure hardware. > > > > > > In my opinion, we should not return PCI

RE: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-21 Thread Akhil Goyal
> On Tue, Oct 22, 2024 at 3:00 AM Thomas Monjalon > wrote: > > > > 08/10/2024 20:49, Akhil Goyal: > > > Added rte_pmd_rvu_lf_bar_get() API to get BAR address > > > for application to configure hardware. > > > > In my opinion, we should not return PCI BAR addresses to an application. > > We should

Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-21 Thread Jerin Jacob
On Tue, Oct 22, 2024 at 3:00 AM Thomas Monjalon wrote: > > 08/10/2024 20:49, Akhil Goyal: > > Added rte_pmd_rvu_lf_bar_get() API to get BAR address > > for application to configure hardware. > > In my opinion, we should not return PCI BAR addresses to an application. > We should make an effort to

Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-21 Thread Thomas Monjalon
08/10/2024 20:49, Akhil Goyal: > Added rte_pmd_rvu_lf_bar_get() API to get BAR address > for application to configure hardware. In my opinion, we should not return PCI BAR addresses to an application. We should make an effort to have all theses details managed in the driver. Giving this level of a

[PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-08 Thread Akhil Goyal
Added rte_pmd_rvu_lf_bar_get() API to get BAR address for application to configure hardware. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst| 7 ++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c | 23 +++ drivers/raw/cnxk_rvu_lf/rte_pmd_cnxk_rvu_