Re: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-10-09 Thread Andrew Rybchenko
diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h index 1e7a3c1527..e7e09e48fc 100644 --- a/lib/mempool/rte_mempool.h +++ b/lib/mempool/rte_mempool.h @@ -1344,31 +1344,41 @@ rte_mempool_do_generic_put(struct rte_mempool *mp, void * const *obj_table, if (unlikely(cache ==

RE: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-10-04 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Wednesday, 2 February 2022 11.34 > > This patch fixes the rte_mempool_do_generic_put() caching algorithm, > which was fundamentally wrong, causing multiple performance issues when > flushing. > > Although the bugs do have serious p

RE: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 7 April 2022 12.44 > > On Thu, Apr 07, 2022 at 11:32:12AM +0100, Bruce Richardson wrote: > > On Thu, Apr 07, 2022 at 11:26:53AM +0200, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.c

Re: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Bruce Richardson
On Thu, Apr 07, 2022 at 11:32:12AM +0100, Bruce Richardson wrote: > On Thu, Apr 07, 2022 at 11:26:53AM +0200, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Thursday, 7 April 2022 11.14 > > > > > > On Thu, Apr 07, 2022 at 11:04:53AM +0200, Morten

Re: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Bruce Richardson
On Thu, Apr 07, 2022 at 11:26:53AM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Thursday, 7 April 2022 11.14 > > > > On Thu, Apr 07, 2022 at 11:04:53AM +0200, Morten Brørup wrote: > > > > From: Morten Brørup [mailto:m...@smartsharesystems.com

RE: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 7 April 2022 11.14 > > On Thu, Apr 07, 2022 at 11:04:53AM +0200, Morten Brørup wrote: > > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > > Sent: Wednesday, 2 February 2022 11.34 > > > > > > This patch fix

Re: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Bruce Richardson
On Thu, Apr 07, 2022 at 11:04:53AM +0200, Morten Brørup wrote: > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > Sent: Wednesday, 2 February 2022 11.34 > > > > This patch fixes the rte_mempool_do_generic_put() caching algorithm, > > which was fundamentally wrong, causing multiple per

RE: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Wednesday, 2 February 2022 11.34 > > This patch fixes the rte_mempool_do_generic_put() caching algorithm, > which was fundamentally wrong, causing multiple performance issues when > flushing. > [...] Olivier, Will you please con

[PATCH v4] mempool: fix mempool cache flushing algorithm

2022-02-02 Thread Morten Brørup
This patch fixes the rte_mempool_do_generic_put() caching algorithm, which was fundamentally wrong, causing multiple performance issues when flushing. Although the bugs do have serious performance implications when flushing, the function did not fail when flushing (or otherwise). Backporting could