Re:Re: [PATCH v4] net/bonding: another fix to LACP mempool size

2022-03-25 Thread Gaoxiang Liu
Hi, Stephen, Min Hu, I will fix the issues. Thanks. Gaoxiang. At 2022-03-09 10:53:15, "Min Hu (Connor)" wrote: >Hi, Stephen, > >在 2022/3/9 9:25, Stephen Hemminger 写道: >> On Tue, 8 Mar 2022 22:24:02 +0800 >> Gaoxiang Liu wrote: >> >>> diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_m

Re: [PATCH v4] net/bonding: another fix to LACP mempool size

2022-03-08 Thread Stephen Hemminger
On Tue, 8 Mar 2022 22:24:02 +0800 Gaoxiang Liu wrote: > + cache_size = RTE_MEMPOOL_CACHE_MAX_SIZE >= 32 ? > + 32 : RTE_MEMPOOL_CACHE_MAX_SIZE; No need to open code a min(). cache_size = RTE_MIN(RTE_MEMPOOL_CACHE_SIZE, 32);

Re: [PATCH v4] net/bonding: another fix to LACP mempool size

2022-03-08 Thread Stephen Hemminger
On Tue, 8 Mar 2022 22:24:02 +0800 Gaoxiang Liu wrote: > diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h > index 1e7a3c1527..fa15ed710f 100644 > --- a/lib/mempool/rte_mempool.h > +++ b/lib/mempool/rte_mempool.h > @@ -56,6 +56,8 @@ > extern "C" { > #endif > > +#define RTE_ME

[PATCH v4] net/bonding: another fix to LACP mempool size

2022-03-08 Thread Gaoxiang Liu
The following log message may appear after a slave is idle(or nearly idle) for a few minutes:"PMD: Failed to allocate LACP packet from pool". And bond mode 4 negotiation may fail. Problem:When bond mode 4 has been chosed and delicated queue has not been enable, all mbufs from a slave' private pool