[PATCH v4] tap: do not duplicate fd's

2024-03-11 Thread Stephen Hemminger
The TAP device can use same file descriptopr for both rx and tx queues. This allows up to 8 queues (versus 4). Signed-off-by: Stephen Hemminger --- v4 - fix typos reported by check patch drivers/net/tap/meson.build | 2 +- drivers/net/tap/rte_eth_tap.c | 197 +++-

Re: [PATCH v4] tap: do not duplicate fd's

2024-04-24 Thread Ferruh Yigit
On 3/11/2024 7:45 PM, Stephen Hemminger wrote: > The TAP device can use same file descriptopr for both rx and tx queues. > This allows up to 8 queues (versus 4). > > Signed-off-by: Stephen Hemminger > --- > v4 - fix typos reported by check patch > > drivers/net/tap/meson.build | 2 +- > dri

Re: [PATCH v4] tap: do not duplicate fd's

2024-04-24 Thread Stephen Hemminger
On Wed, 24 Apr 2024 17:57:46 +0100 Ferruh Yigit wrote: > OK to merge file descriptors instead of duplicating them. > > But we have this 4 queue limitation only for multi process case, right? > If user is planning to use only with primary, this will reduce the > supported queue number. > > Does

Re: [PATCH v4] tap: do not duplicate fd's

2024-04-25 Thread Ferruh Yigit
On 4/24/2024 8:04 PM, Stephen Hemminger wrote: > Yes, the lower limit only applies to the secondary process. > But any application using secondary processes will have the problem; > i.e it is not that primary gets 16 and the secondary only sees 8. > > Lets keep MAX_QUEUES at 16 for now, and let us

Re: [PATCH v4] tap: do not duplicate fd's

2024-04-25 Thread Ferruh Yigit
On 4/24/2024 8:04 PM, Stephen Hemminger wrote: > On Wed, 24 Apr 2024 17:57:46 +0100 > Ferruh Yigit wrote: > >> OK to merge file descriptors instead of duplicating them. >> >> But we have this 4 queue limitation only for multi process case, right? >> If user is planning to use only with primary, t