Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

On Tue, Feb 20, 2024 at 08:16:23PM +0100, Thomas Monjalon wrote: > 20/02/2024 18:53, Thomas Monjalon: > > 20/02/2024 18:20, Tyler Retzlaff: > > > On Sun, Feb 18, 2024 at 01:39:52PM +0100, Thomas Monjalon wrote: > > > > 15/02/2024 07:21, Tyler Retzlaff: > > > > > Provide a macro that allows conditio

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

20/02/2024 18:53, Thomas Monjalon: > 20/02/2024 18:20, Tyler Retzlaff: > > On Sun, Feb 18, 2024 at 01:39:52PM +0100, Thomas Monjalon wrote: > > > 15/02/2024 07:21, Tyler Retzlaff: > > > > Provide a macro that allows conditional expansion of RTE_MARKER fields > > > > to empty to allow rte_mbuf to be

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

20/02/2024 18:20, Tyler Retzlaff: > On Sun, Feb 18, 2024 at 01:39:52PM +0100, Thomas Monjalon wrote: > > 15/02/2024 07:21, Tyler Retzlaff: > > > Provide a macro that allows conditional expansion of RTE_MARKER fields > > > to empty to allow rte_mbuf to be used with MSVC. It is proposed that > > > we

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

On Sun, Feb 18, 2024 at 04:22:15PM +0100, Thomas Monjalon wrote: > 18/02/2024 14:07, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 15/02/2024 07:21, Tyler Retzlaff: > > > > --- a/lib/eal/include/rte_common.h > > > > +++ b/lib/eal/include/rte_common.h > > > > @@ -582,6

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

On Sun, Feb 18, 2024 at 01:39:52PM +0100, Thomas Monjalon wrote: > 15/02/2024 07:21, Tyler Retzlaff: > > Provide a macro that allows conditional expansion of RTE_MARKER fields > > to empty to allow rte_mbuf to be used with MSVC. It is proposed that > > we announce the fields to be __rte_deprecated

RE: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, 18 February 2024 16.22 > > 18/02/2024 14:07, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 15/02/2024 07:21, Tyler Retzlaff: > > > > --- a/lib/eal/include/rte_common.h > > > > +++ b/lib/eal/include/r

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

18/02/2024 14:07, Morten Brørup: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 15/02/2024 07:21, Tyler Retzlaff: > > > --- a/lib/eal/include/rte_common.h > > > +++ b/lib/eal/include/rte_common.h > > > @@ -582,6 +582,12 @@ static void > > __attribute__((destructor(RTE_PRIO(prio)), used))

RE: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, 18 February 2024 13.40 > > 15/02/2024 07:21, Tyler Retzlaff: > > Provide a macro that allows conditional expansion of RTE_MARKER > fields > > to empty to allow rte_mbuf to be used with MSVC. It is proposed that > > we announce th

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

15/02/2024 07:21, Tyler Retzlaff: > Provide a macro that allows conditional expansion of RTE_MARKER fields > to empty to allow rte_mbuf to be used with MSVC. It is proposed that > we announce the fields to be __rte_deprecated (currently disabled). > > Introduce C11 anonymous unions to permit alias

Re: [PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

Some minor comments style may need adjust. With above fixed, Acked-by: Chengwen Feng On 2024/2/15 14:21, Tyler Retzlaff wrote: > Provide a macro that allows conditional expansion of RTE_MARKER fields > to empty to allow rte_mbuf to be used with MSVC. It is proposed that > we announce the fields

[PATCH v4 01/18] mbuf: deprecate GCC marker in rte mbuf struct

Provide a macro that allows conditional expansion of RTE_MARKER fields to empty to allow rte_mbuf to be used with MSVC. It is proposed that we announce the fields to be __rte_deprecated (currently disabled). Introduce C11 anonymous unions to permit aliasing of well-known offsets by name into the r