Re: [PATCH v5] app/testpmd: txonly multiflow port change support

2023-05-17 Thread Ferruh Yigit
On 4/22/2023 12:20 AM, Joshua Washington wrote: > Google cloud routes traffic using IP addresses without the support of MAC > addresses, so changing source IP address for txonly-multi-flow can have > negative performance implications for net/gve when using testpmd. This > patch updates txonly multi

Re: [PATCH v5] app/testpmd: txonly multiflow port change support

2023-05-17 Thread Ferruh Yigit
On 5/16/2023 6:32 PM, Joshua Washington wrote: > Hello, > > I believe my original solution was something closer to what you are > suggesting for backward compatibility. I originally had a flag that > enabled changing source port instead of source IP addresses, but I > received feedback that adding

Re: [PATCH v5] app/testpmd: txonly multiflow port change support

2023-05-16 Thread Joshua Washington
Hello, I believe my original solution was something closer to what you are suggesting for backward compatibility. I originally had a flag that enabled changing source port instead of source IP addresses, but I received feedback that adding an extra flag was complicating things too much from Stephe

Re: [PATCH v5] app/testpmd: txonly multiflow port change support

2023-05-15 Thread Ferruh Yigit
On 4/22/2023 12:20 AM, Joshua Washington wrote: > Google cloud routes traffic using IP addresses without the support of MAC > addresses, so changing source IP address for txonly-multi-flow can have > negative performance implications for net/gve when using testpmd. This > patch updates txonly multi

Re: [PATCH v5] app/testpmd: txonly multiflow port change support

2023-05-15 Thread Joshua Washington
Does this patch need anything else to be done before it can be merged? I'm hoping to get this patch merged as part of the 23.07 release. Thanks, Josh

Re: [PATCH v5] app/testpmd: txonly multiflow port change support

2023-04-26 Thread Singh, Aman Deep
On 4/22/2023 4:50 AM, Joshua Washington wrote: Google cloud routes traffic using IP addresses without the support of MAC addresses, so changing source IP address for txonly-multi-flow can have negative performance implications for net/gve when using testpmd. This patch updates txonly multiflow

Re: [PATCH v5] app/testpmd: txonly multiflow port change support

2023-04-24 Thread David Marchand
Hello Joshua, On Mon, Apr 24, 2023 at 7:56 PM Joshua Washington wrote: > > After updating the patch, it seems that the `lcores_autotest` unit test now > times out on Windows Server 2019. I looked at the test logs, but they were > identical as far as I could tell, with the timed out test even pr

Re: [PATCH v5] app/testpmd: txonly multiflow port change support

2023-04-24 Thread Joshua Washington
After updating the patch, it seems that the `lcores_autotest` unit test now times out on Windows Server 2019. I looked at the test logs, but they were identical as far as I could tell, with the timed out test even printing "Test OK" to stdout. Is this a flake? Or is there any other way to get extra

[PATCH v5] app/testpmd: txonly multiflow port change support

2023-04-21 Thread Joshua Washington
Google cloud routes traffic using IP addresses without the support of MAC addresses, so changing source IP address for txonly-multi-flow can have negative performance implications for net/gve when using testpmd. This patch updates txonly multiflow mode to modify source ports instead of source IP ad