[PATCH v5] graph: expose node context as pointers

2024-03-27 Thread Robin Jarry
In some cases, the node context data is used to store two pointers because the data is larger than the reserved 16 bytes. Having to define intermediate structures just to be able to cast is tedious. And without intermediate structures, casting to opaque pointers is hard without violating strict ali

Re: [PATCH v5] graph: expose node context as pointers

2024-05-29 Thread Nithin Dabilpuram
Acked-by: Nithin Dabilpuram On Wed, Mar 27, 2024 at 2:47 PM Robin Jarry wrote: > > In some cases, the node context data is used to store two pointers > because the data is larger than the reserved 16 bytes. Having to define > intermediate structures just to be able to cast is tedious. And withou

Re: [PATCH v5] graph: expose node context as pointers

2024-06-18 Thread David Marchand
Re Robin, On Wed, Mar 27, 2024 at 10:17 AM Robin Jarry wrote: > > In some cases, the node context data is used to store two pointers > because the data is larger than the reserved 16 bytes. Having to define > intermediate structures just to be able to cast is tedious. And without > intermediate s

Re: [PATCH v5] graph: expose node context as pointers

2024-06-25 Thread Robin Jarry
Sad :( The introduced anonymous structure gets aligned on the minimum cache line size (64 bytes): with this change, ctx[] move from offset 256, to offset 192. Similarly, nodes[] moves from offset 320 to offset 256. As we discussed offlist, there are a few options to workaround this issue (like

Re: [PATCH v5] graph: expose node context as pointers

2024-06-26 Thread Jerin Jacob
On Tue, Jun 25, 2024 at 9:02 PM Robin Jarry wrote: > > Sad :( > > > The introduced anonymous structure gets aligned on the minimum cache > > line size (64 bytes): with this change, ctx[] move from offset 256, to > > offset 192. > > Similarly, nodes[] moves from offset 320 to offset 256. > > > > As