Re: [PATCH v5] net/netvsc: fix parsing of VLAN metadata

2024-02-16 Thread Ferruh Yigit
On 2/15/2024 6:12 PM, Alan Elder wrote: > The previous code incorrectly parsed the VLAN ID and priority. > If the 16-bits of VLAN ID and priority/CFI on the wire was > 0123456789ABCDEF the code parsed it as 456789ABCDEF3012. There > were macros defined to handle this conversion but they were not >

Re: [PATCH v5] net/netvsc: fix parsing of VLAN metadata

2024-02-15 Thread Stephen Hemminger
On Thu, 15 Feb 2024 18:12:35 + Alan Elder wrote: > +/* VLAN header fields */ > +#define RTE_VLAN_DEI_SHIFT 12 > +#define RTE_VLAN_PRI_SHIFT 13 > +#define RTE_VLAN_PRI_MASK0xe000 /* Priority Code Point */ > +#define RTE_VLAN_DEI_MASK0x1000 /* Drop Eligible Indicator */ > +#define R

[PATCH v5] net/netvsc: fix parsing of VLAN metadata

2024-02-15 Thread Alan Elder
The previous code incorrectly parsed the VLAN ID and priority. If the 16-bits of VLAN ID and priority/CFI on the wire was 0123456789ABCDEF the code parsed it as 456789ABCDEF3012. There were macros defined to handle this conversion but they were not used. Fixes: 4e9c73e96e83 ("net/netvsc: add Hype