Re: [PATCH v5 1/3] dts: updated testpmd shell class

2024-06-21 Thread Jeremy Spewock
Just documentation comments, the structure of the code and the functionality look good to me. Maybe a different subject for the commit would be more descriptive. Something like "add methods required for VLAN test suite to TestpmdShell". Then you can explain what methods are added in the descriptio

[PATCH v5 1/3] dts: updated testpmd shell class

2024-06-18 Thread Dean Marx
Ported over the promisc and verbose mode functions from v2 of the queue start/stop suite to use for the VLAN suite. Tweaked some of the verification methods to be more concise, changed some docstrings to be more specific. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.