RE: [PATCH v5 2/4] lib: fix comparison between devices

2025-02-19 Thread Shani Peretz
; dev@dpdk.org; Parav Pandit > ; Xueming Li ; Nipun Gupta > ; Nikhil Agarwal ; Hemant > Agrawal ; Sachin Saxena > ; Rosen Xu ; Chenbo Xia > ; Tomasz Duszynski ; > Chengwen Feng ; NBU-Contact-longli > (EXTERNAL) ; Wei Hu ; Kevin > Laatz ; Tyler Retzlaff ; > Jan Blun

Re: [PATCH v5 2/4] lib: fix comparison between devices

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 17:54:26 + Bruce Richardson wrote: > On Tue, Feb 11, 2025 at 09:48:32AM -0800, Stephen Hemminger wrote: > > On Thu, 6 Feb 2025 02:08:36 +0200 > > Shani Peretz wrote: > > > > > static int > > > -cdx_parse(const char *name, void *addr) > > > +cdx_parse(const char *name,

Re: [PATCH v5 2/4] lib: fix comparison between devices

2025-02-11 Thread Bruce Richardson
On Tue, Feb 11, 2025 at 09:48:32AM -0800, Stephen Hemminger wrote: > On Thu, 6 Feb 2025 02:08:36 +0200 > Shani Peretz wrote: > > > static int > > -cdx_parse(const char *name, void *addr) > > +cdx_parse(const char *name, void *addr, int *size) > > { > > - const char **out = addr; > > int r

Re: [PATCH v5 2/4] lib: fix comparison between devices

2025-02-11 Thread Stephen Hemminger
On Thu, 6 Feb 2025 02:08:36 +0200 Shani Peretz wrote: > static int > -cdx_parse(const char *name, void *addr) > +cdx_parse(const char *name, void *addr, int *size) > { > - const char **out = addr; > int ret; > > ret = strncmp(name, CDX_DEV_PREFIX, strlen(CDX_DEV_PREFIX)); >

RE: [PATCH v5 2/4] lib: fix comparison between devices

2025-02-09 Thread Xu, Rosen
; Xu, Rosen ; > Chenbo Xia ; Tomasz Duszynski > ; Chengwen Feng > ; Long Li ; Wei Hu > ; Richardson, Bruce ; > Laatz, Kevin ; Tyler Retzlaff > ; Jan Blunck > Subject: [PATCH v5 2/4] lib: fix comparison between devices > > DPDK supports multiple formats for specifying buses, (s

Re: [PATCH v5 2/4] lib: fix comparison between devices

2025-02-05 Thread Hemant Agrawal
On 06-02-2025 05:38, Shani Peretz wrote: DPDK supports multiple formats for specifying buses, (such as ":08:00.0" and "08:00.0" for PCI). This flexibility can lead to inconsistencies when using one format while running testpmd, then attempts to use the other format in a later command, resul

[PATCH v5 2/4] lib: fix comparison between devices

2025-02-05 Thread Shani Peretz
DPDK supports multiple formats for specifying buses, (such as ":08:00.0" and "08:00.0" for PCI). This flexibility can lead to inconsistencies when using one format while running testpmd, then attempts to use the other format in a later command, resulting in a failure. The issue arises from the