Re: [PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

2023-01-19 Thread Kevin Laatz
On 19/01/2023 15:06, Robin Jarry wrote: Allow fetching CPU cycles usage for all lcores with a single request. This endpoint is intended for repeated and frequent invocations by external monitoring systems and therefore returns condensed data. It consists of a single dictionary with three keys: "

RE: [PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

2023-01-19 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Thursday, 19 January 2023 17.35 > > Morten Brørup, Jan 19, 2023 at 17:21: > > In the future, the rte_lcore_usage structure may contain more fields, > > and some may not be related to the TSC. So consider removing "cycles" > > from the descript

Re: [PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

2023-01-19 Thread Robin Jarry
Morten Brørup, Jan 19, 2023 at 17:21: > In the future, the rte_lcore_usage structure may contain more fields, > and some may not be related to the TSC. So consider removing "cycles" > from the description of the telemetry path. > > Don't waste time changing it unless you are providing a new patch >

RE: [PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

2023-01-19 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Thursday, 19 January 2023 16.07 > > Allow fetching CPU cycles usage for all lcores with a single request. > This endpoint is intended for repeated and frequent invocations by > external monitoring systems and therefore returns condensed data.

[PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

2023-01-19 Thread Robin Jarry
Allow fetching CPU cycles usage for all lcores with a single request. This endpoint is intended for repeated and frequent invocations by external monitoring systems and therefore returns condensed data. It consists of a single dictionary with three keys: "lcore_ids", "total_cycles" and "busy_cycle