RE: [PATCH v7 16/19] event/dlb2: use dedicated logtype

2024-02-05 Thread Sevincer, Abdullah
>+I don't understand why you would say that. >+The message already will get a single newline and your change would add a >second one. >+Log messages are not supposed to be double spaced, it confuses syslog. >+If you want to change the overall format of log messages and how it displays >the fun

Re: [PATCH v7 16/19] event/dlb2: use dedicated logtype

2024-02-05 Thread Stephen Hemminger
On Mon, 5 Feb 2024 19:16:15 + "Sevincer, Abdullah" wrote: > >+DLB2_LOG_INFO("Ignoring unsupported parameters when > >creating device '%s'", > name); > > Hi Stephen can you modify above like this: > > DLB2_LOG_INFO(": Ignoring unsupp

RE: [PATCH v7 16/19] event/dlb2: use dedicated logtype

2024-02-05 Thread Sevincer, Abdullah
>+ DLB2_LOG_INFO("Ignoring unsupported parameters when >creating device '%s'", name); Hi Stephen can you modify above like this: DLB2_LOG_INFO(": Ignoring unsupported parameters when creating device '%s'\n", name); It looks better this

[PATCH v7 16/19] event/dlb2: use dedicated logtype

2024-02-02 Thread Stephen Hemminger
Driver was using RTE_LOGTYPE_PMD when it had its own logtype. Fixes: 5433956d5185 ("event/dlb2: add eventdev probe") Signed-off-by: Stephen Hemminger --- drivers/event/dlb2/dlb2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/d