RE: [PATCH v7 5/5] ethdev: format module EEPROM for SFF-8636

Hi, David This is a good suggestion and I will adopt it, send v8. Thanks! > -Original Message- > From: David Marchand > Sent: Tuesday, May 24, 2022 5:04 PM > To: Zhang, RobinX > Cc: dev ; Thomas Monjalon ; > Andrew Rybchenko ; Liu, KevinX > > Subject: Re: [PATC

Re: [PATCH v7 5/5] ethdev: format module EEPROM for SFF-8636

Hello, I see a lot of switch / case where tables could do the job. In any case, I'll focus only on one part of the code, that triggers a build warning witch clang 14 (+ ASan): On Tue, May 24, 2022 at 8:31 AM Robin Zhang wrote: > + /* Channel Specific Data */ > + for (i = 0; i < MAX_C

[PATCH v7 5/5] ethdev: format module EEPROM for SFF-8636

This patch implements format module EEPROM information for SFF-8636 Rev 2.7 Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 4 + lib/ethdev/meson.build| 1 + lib/ethdev/sff_8636.c | 775 ++ lib/ethdev/sff_8636.h