[PATCH v8] sched: enable CMAN at runtime

2022-07-05 Thread Marcin Danilewicz
Added changes to enable CMAN (RED or PIE) at init from profile configuration file. By default CMAN code is enable but not in use, when there is no RED or PIE profile configured. Signed-off-by: Marcin Danilewicz --- Log: v2 change in rte_sched.h to avoid ABI breakage. v3 changes from comment

RE: [PATCH v8] sched: enable CMAN at runtime

2022-07-05 Thread Ajmera, Megha
> > Added changes to enable CMAN (RED or PIE) at init from profile configuration > file. > > By default CMAN code is enable but not in use, when there is no RED or PIE > profile configured. > > Signed-off-by: Marcin Danilewicz > --- > Log: v2 change in rte_sched.h to avoid ABI breakage. >

RE: [PATCH v8] sched: enable CMAN at runtime

2022-07-05 Thread Danilewicz, MarcinX
> Here only mode is set to RTE_SCHED_CMAN_RED. But I could not find the > place where cman_params are set from cfg_file (for e.g. red_params). Can > you clarify? Look beyond that particular change. All this is joined work. I am adding final touch to what I've started, he continued and now we all

RE: [PATCH v8] sched: enable CMAN at runtime

2022-07-06 Thread Singh, Jasvinder
> -Original Message- > From: Danilewicz, MarcinX > Sent: Tuesday, July 5, 2022 6:06 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v8] sched: enable CMAN at runtime > > Added changes to enable CMA

RE: [PATCH v8] sched: enable CMAN at runtime

2022-07-07 Thread Danilewicz, MarcinX
> > Signed-off-by: Marcin Danilewicz > > --- > > Log: v2 change in rte_sched.h to avoid ABI breakage. > > v3 changes from comments > > v4 rebase to 22.07-rc1 > > v5 rebase to main latest > > v6 commit message fixed > > v7 changes from comments > > v8 with changes fro

RE: [PATCH v8] sched: enable CMAN at runtime

2022-07-07 Thread Singh, Jasvinder
> > > -#ifdef RTE_SCHED_CMAN > > > - set_subport_cman_params(subport_params+i, > > > cman_params); > > > -#endif > > > + subport_params[i].cman_params = &cman_params; > > > > Since cman_params_is global variable, memory is allocated regardless > > of whether cman

RE: [PATCH v8] sched: enable CMAN at runtime

2022-07-07 Thread Danilewicz, MarcinX
> > For an instance: > > If (cman_params.cman_mode == RTE_SCHED_CMAN_PIE || > > cman_params.cman_mode == RTE_SCHED_CMAN_RED) { Then set > > subport_params[i].cman_params to cman_params. > > } > > Yes, this is correct as well. I'm happy to hear that.